Spec URL: https://jjames.fedorapeople.org/qsopt-ex/qsopt-ex.spec SRPM URL: https://jjames.fedorapeople.org/qsopt-ex/qsopt-ex-2.5.10.3-1.20170729gite5d498f.fc40.src.rpm Fedora Account System Username: jjames Description: QSopt_ex is an exact linear programming solver. This is a fork of the version originally released by Daniel Espinoza et al. The goal of the fork is to update the software, and in particular the build system, to be more friendly. In addition, the external dependencies have been reduced.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6558695 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245710-qsopt-ex/fedora-rawhide-x86_64/06558695-qsopt-ex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later [generated file]", "GNU Lesser General Public License v2.1 or later", "GNU General Public License", "GNU General Public License v3.0 or later", "GNU General Public License v2.0 or later and/or GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3". 25 files have unknown license. Detailed output of licensecheck in /home/solopasha/build/review/2245710-qsopt- ex/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4614 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qsopt- ex-libs , qsopt-ex-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qsopt-ex-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm qsopt-ex-libs-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm qsopt-ex-devel-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm qsopt-ex-debuginfo-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm qsopt-ex-debugsource-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm qsopt-ex-2.5.10.3-1.20170729gite5d498f.fc40.src.rpm =============================================================== rpmlint session starts ============================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpeh33afeh')] checks: 31, packages: 6 qsopt-ex.spec: W: patch-not-applied Patch0: %{name}-free-warning.patch qsopt-ex.spec: W: patch-not-applied Patch1: %{name}-silence-mempool-log.patch qsopt-ex-devel.x86_64: W: no-documentation ================================ 6 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.7 s =============================== Rpmlint (debuginfo) ------------------- Checking: qsopt-ex-libs-debuginfo-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm qsopt-ex-debuginfo-2.5.10.3-1.20170729gite5d498f.fc40.x86_64.rpm =============================================================== rpmlint session starts ============================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpacq7iogf')] checks: 31, packages: 2 ================================ 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s =============================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 qsopt-ex-devel.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.8 s Source checksums ---------------- https://github.com/jonls/qsopt-ex/archive/e5d498fde468e4669a3fbc4736e5d3b878e8c148/qsopt-ex-e5d498fde468e4669a3fbc4736e5d3b878e8c148.tar.gz : CHECKSUM(SHA256) this package : 2057309accfe27fee553090e19f0c051a101e393a758cc31549e194a88bf0fbe CHECKSUM(SHA256) upstream package : 2057309accfe27fee553090e19f0c051a101e393a758cc31549e194a88bf0fbe Requires -------- qsopt-ex (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgmp.so.10()(64bit) libqsopt_ex.so.2()(64bit) qsopt-ex-libs(x86-64) rtld(GNU_HASH) qsopt-ex-libs (rpmlib, GLIBC filtered): libbz2.so.1()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) qsopt-ex-devel (rpmlib, GLIBC filtered): libqsopt_ex.so.2()(64bit) qsopt-ex-libs(x86-64) qsopt-ex-debuginfo (rpmlib, GLIBC filtered): qsopt-ex-debugsource (rpmlib, GLIBC filtered): Provides -------- qsopt-ex: qsopt-ex qsopt-ex(x86-64) qsopt-ex-libs: libqsopt_ex.so.2()(64bit) qsopt-ex-libs qsopt-ex-libs(x86-64) qsopt-ex-devel: qsopt-ex-devel qsopt-ex-devel(x86-64) qsopt-ex-debuginfo: debuginfo(build-id) qsopt-ex-debuginfo qsopt-ex-debuginfo(x86-64) qsopt-ex-debugsource: qsopt-ex-debugsource qsopt-ex-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: /home/solopasha/build/review/2245710-qsopt- ex/upstream-unpacked/Source0/qsopt- ex-e5d498fde468e4669a3fbc4736e5d3b878e8c148/configure.ac:37 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2245710 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Haskell, PHP, fonts, Perl, Ocaml, R, Java, SugarActivity, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH > AutoTools: Obsoleted m4s found Can be fixed with sed -i 's/AC_PROG_LIBTOOL/LT_INIT/' configure.ac > qsopt-ex.spec: W: patch-not-applied Patch0: %{name}-free-warning.patch > qsopt-ex.spec: W: patch-not-applied Patch1: %{name}-silence-mempool-log.patch Seems false positive... a review for https://bugzilla.redhat.com/show_bug.cgi?id=2244378 would be greatly appreciated, thanks
Thank you for the review! There were several obsolete macros in configure.ac. I finally resorted to this: # Update obsolete macros sed -i '/AC_HEADER_STDC/d;/AC_HEADER_TIME/d;/AC_TYPE_SIGNAL/d' configure.ac sed -i 's/AC_PROG_LIBTOOL/LT_INIT/' configure.ac autoupdate -f Also, you are right about the fedora-review false positive. I'll see if I can track that down and file a bug.
The Pagure repository was created at https://src.fedoraproject.org/rpms/qsopt-ex
FEDORA-2023-7d91d2863e has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7d91d2863e
FEDORA-2023-7d91d2863e has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.