Spec URL: https://ppisar.fedorapeople.org/perl-Grpc-XS/perl-Grpc-XS.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Grpc-XS/perl-Grpc-XS-0.38-2.fc40.src.rpm Description: This is a low-level binding to a client part of the gRPC library. Fedora Account System Username: ppisar This is re-review for renaming perl-grpc-xs (bug #1688786) to perl-Grpc-XS to follow an upstream.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Grpc-XS-0.38-2.fc40.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 ld-linux-x86-64.so.2()(64bit) 1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.38)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libgrpc.so.26()(64bit) 1 libperl.so.5.38()(64bit) 1 perl(base) 1 perl(constant) 1 perl(Exporter) 1 perl(Grpc::Client::AbstractCall) 1 perl(Grpc::Client::BidiStreamingCall) 1 perl(Grpc::Client::ClientStreamingCall) 1 perl(Grpc::Client::ServerStreamingCall) 1 perl(Grpc::Client::UnaryCall) 1 perl(Grpc::Constants) 1 perl(Grpc::XS) 1 perl(Grpc::XS::Call) 1 perl(Grpc::XS::CallCredentials) 1 perl(Grpc::XS::Channel) 1 perl(Grpc::XS::Constants) 1 perl(Grpc::XS::Timeval) 1 perl-libs 1 perl(:MODULE_COMPAT_5.38.0) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Grpc-XS-0.38-2.fc40.x86_64.rpm | sort | uniq -c 1 perl(Grpc::Client::AbstractCall) 1 perl(Grpc::Client::BaseStub) 1 perl(Grpc::Client::BidiStreamingCall) 1 perl(Grpc::Client::ClientStreamingCall) 1 perl(Grpc::Client::ServerStreamingCall) 1 perl(Grpc::Client::UnaryCall) 1 perl(Grpc::Constants) 1 perl(Grpc::XS) = 0.38 1 perl-Grpc-XS = 0.38-2.fc40 1 perl(Grpc::XS::Call) 1 perl(Grpc::XS::CallCredentials) 1 perl(Grpc::XS::Channel) 1 perl(Grpc::XS::ChannelCredentials) 1 perl(Grpc::XS::Constants) 1 perl(Grpc::XS::Server) 1 perl(Grpc::XS::ServerCredentials) 1 perl(Grpc::XS::Timeval) 1 perl-grpc-xs(x86-64) = 0.38-2.fc40 1 perl-Grpc-XS(x86-64) = 0.38-2.fc40 Binary provides are Ok. $ rpmlint ./perl-Grpc-XS* ================================== rpmlint session starts ================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 perl-Grpc-XS.x86_64: W: obsolete-not-provided perl-grpc-xs perl-Grpc-XS-tests.noarch: W: no-documentation === 3 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.4 s === Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
Thanks for the review. Could you please explicitly note here that you check the package rename as requested in <https://docs.fedoraproject.org/en-US/fesco/Package_rename_policy/#re_review_required>.
$ rpm -qp --obsoletes perl-Grpc-XS-0.38-2.fc40.x86_64.rpm | grep perl-grpc-xs perl-grpc-xs < 0.38-2 Obsoletes contains perl-grpc-xs which is renaming. $ rpm -qpP perl-Grpc-XS-0.38-2.fc40.x86_64.rpm | grep perl-grpc-xs perl-grpc-xs(x86-64) = 0.38-2.fc40 List of provides contains perl-grpc-xs(x86-64) TODO: Please consider to remove '%{?_isa}' from the provides or add provides 'perl-grpc-xs = 0.38-2.fc40' to remove rpmlint warning perl-Grpc-XS.x86_64: W: obsolete-not-provided perl-grpc-xs
The package perl-grpc-xs contains both. perl-grpc-xs = 0.38-1.fc40 perl-grpc-xs(x86_64) = 0.38-1.fc40
https://pagure.io/releng/fedora-scm-requests/issue/58067
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Grpc-XS
Good catch. I was so obsessed with the architecture that I forgot to provide the package name. I fixed it in dist-git.
It seems that upstream reverted his decision and returned back to grpc-xs name: <https://metacpan.org/dist/Grpc-XS> fails now. <https://metacpan.org/dist/grpc-xs> enumerates 0.38 now. <https://cpan.metacpan.org/authors/id/J/JO/JOYREX/> confirms that upstream returned to the original name after 3 days. I'm sorry for bothering you with this review. I will retire this package. I cancelled perl-Grpc-XS build before finishing the build.