Spec URL: https://decathorpe.fedorapeople.org/elementary-calendar.spec SRPM URL: https://decathorpe.fedorapeople.org/elementary-calendar-7.0.0-1.fc39.src.rpm Description: A slim, lightweight calendar app that syncs and manages multiple calendars in one place, like Google Calendar, Outlook and CalDAV. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109417319
Copr build: https://copr.fedorainfracloud.org/coprs/build/6681038 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251102-elementary-calendar/srpm-builds/06681038/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6695811 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251102-elementary-calendar/fedora-rawhide-x86_64/06695811-elementary-calendar/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-calendar Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-calendar See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License v3.0 or later", "GNU Library General Public License v2 or later", "GNU General Public License v2.0 or later", "GNU Lesser General Public License v2.1 or later". 229 files have unknown license. Detailed output of licensecheck in /home/fedora/2251102-elementary- calendar/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/mo [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/mo [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 841 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1187840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: elementary-calendar-7.0.0-1.fc40.x86_64.rpm elementary-calendar-devel-7.0.0-1.fc40.x86_64.rpm elementary-calendar-debuginfo-7.0.0-1.fc40.x86_64.rpm elementary-calendar-debugsource-7.0.0-1.fc40.x86_64.rpm elementary-calendar-7.0.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_492byjj')] checks: 31, packages: 5 elementary-calendar.x86_64: W: no-manual-page-for-binary io.elementary.calendar elementary-calendar-devel.x86_64: W: no-documentation elementary-calendar.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/io.elementary.calendar.mo elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/128x128/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/16x16/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/24x24/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/32x32/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/48x48/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/64x64/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/locale/my/LC_MESSAGES/io.elementary.calendar.mo /usr/share/locale/cv/LC_MESSAGES/io.elementary.calendar.mo elementary-calendar.x86_64: W: files-duplicate /usr/share/locale/kn/LC_MESSAGES/io.elementary.calendar.mo /usr/share/locale/is/LC_MESSAGES/io.elementary.calendar.mo elementary-calendar.x86_64: W: files-duplicate /usr/share/locale/mn/LC_MESSAGES/io.elementary.calendar.mo /usr/share/locale/mg/LC_MESSAGES/io.elementary.calendar.mo 5 packages and 0 specfiles checked; 1 errors, 11 warnings, 1 badness; has taken 1.2 s Rpmlint (debuginfo) ------------------- Checking: elementary-calendar-debuginfo-7.0.0-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1n27eqw9')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 elementary-calendar.x86_64: W: no-manual-page-for-binary io.elementary.calendar elementary-calendar-devel.x86_64: W: no-documentation elementary-calendar.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/io.elementary.calendar.mo elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/128x128/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/16x16/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/24x24/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/32x32/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/48x48/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/io.elementary.calendar.svg /usr/share/icons/hicolor/64x64/apps/io.elementary.calendar.svg elementary-calendar.x86_64: W: files-duplicate /usr/share/locale/my/LC_MESSAGES/io.elementary.calendar.mo /usr/share/locale/cv/LC_MESSAGES/io.elementary.calendar.mo elementary-calendar.x86_64: W: files-duplicate /usr/share/locale/kn/LC_MESSAGES/io.elementary.calendar.mo /usr/share/locale/is/LC_MESSAGES/io.elementary.calendar.mo elementary-calendar.x86_64: W: files-duplicate /usr/share/locale/mn/LC_MESSAGES/io.elementary.calendar.mo /usr/share/locale/mg/LC_MESSAGES/io.elementary.calendar.mo 4 packages and 0 specfiles checked; 1 errors, 11 warnings, 127 filtered, 1 badness; has taken 2.5 s Unversioned so-files -------------------- elementary-calendar: /usr/lib64/io.elementary.calendar/plugins/CalDAV/libcaldav.so elementary-calendar: /usr/lib64/io.elementary.calendar/plugins/Google/libgoogle.so Source checksums ---------------- https://github.com/elementary/calendar/archive/7.0.0/calendar-7.0.0.tar.gz : CHECKSUM(SHA256) this package : 389a46896b8cf883ef30cf60eab9edd397cfa38a2375164f833921b1ff72aefc CHECKSUM(SHA256) upstream package : 389a46896b8cf883ef30cf60eab9edd397cfa38a2375164f833921b1ff72aefc Requires -------- elementary-calendar (rpmlib, GLIBC filtered): hicolor-icon-theme libc.so.6()(64bit) libchamplain-0.12.so.0()(64bit) libchamplain-gtk-0.12.so.0()(64bit) libclutter-1.0.so.0()(64bit) libclutter-gtk-1.0.so.0()(64bit) libecal-2.0.so.2()(64bit) libedataserver-1.2.so.27()(64bit) libedataserverui-1.2.so.4()(64bit) libelementary-calendar.so.0()(64bit) libfolks.so.26()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee-0.8.so.2()(64bit) libgeoclue-2.so.0()(64bit) libgeocode-glib-2.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite.so.6()(64bit) libgtk-3.so.0()(64bit) libhandy-1.so.0()(64bit) libhandy-1.so.0(LIBHANDY_1_0)(64bit) libical-glib.so.3()(64bit) libportal-gtk3.so.1()(64bit) libportal.so.1()(64bit) rtld(GNU_HASH) elementary-calendar-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config elementary-calendar(x86-64) libelementary-calendar.so.0()(64bit) pkgconfig(gee-0.8) pkgconfig(glib-2.0) pkgconfig(gmodule-2.0) pkgconfig(granite) pkgconfig(gtk+-3.0) pkgconfig(libecal-2.0) pkgconfig(libedataserver-1.2) pkgconfig(libedataserverui-1.2) pkgconfig(libical-glib) elementary-calendar-debuginfo (rpmlib, GLIBC filtered): elementary-calendar-debugsource (rpmlib, GLIBC filtered): Provides -------- elementary-calendar: application() application(io.elementary.calendar.desktop) elementary-calendar elementary-calendar(x86-64) libelementary-calendar.so.0()(64bit) metainfo() metainfo(io.elementary.calendar.metainfo.xml) mimehandler(text/calendar) elementary-calendar-devel: elementary-calendar-devel elementary-calendar-devel(x86-64) pkgconfig(elementary-calendar) elementary-calendar-debuginfo: debuginfo(build-id) elementary-calendar-debuginfo elementary-calendar-debuginfo(x86-64) libcaldav.so-7.0.0-1.fc40.x86_64.debug()(64bit) libelementary-calendar.so.0.1-7.0.0-1.fc40.x86_64.debug()(64bit) libgoogle.so-7.0.0-1.fc40.x86_64.debug()(64bit) elementary-calendar-debugsource: elementary-calendar-debugsource elementary-calendar-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251102 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: R, fonts, Python, Haskell, Ocaml, PHP, Java, SugarActivity, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Svg icons should go into /usr/share/icons/hicolor/scalable b) Builds on all architectures https://koji.fedoraproject.org/koji/taskinfo?taskID=109417319 c) Package seems to have additional licenses: *No copyright* GNU General Public License v3.0 or later ------------------------------------------------------- calendar-7.0.0/core/Services/Calendar/EventStore.vala calendar-7.0.0/core/Utils.vala GNU General Public License v2.0 or later ---------------------------------------- calendar-7.0.0/core/Services/Calendar/Util/DateIterator.vala calendar-7.0.0/core/Services/Calendar/Util/DateRange.vala calendar-7.0.0/core/Services/Calendar/Util/DateTime.vala calendar-7.0.0/core/Services/Calendar/Util/ECalComponent.vala calendar-7.0.0/core/Services/Calendar/Util/ICalComponent.vala calendar-7.0.0/core/Services/Calendar/Util/ICalTime.vala calendar-7.0.0/core/Tests/util-tests.vala GNU General Public License v3.0 or later ---------------------------------------- calendar-7.0.0/core/GesturesUtils.vala calendar-7.0.0/data/style/Grid.css calendar-7.0.0/data/style/Header.css calendar-7.0.0/data/style/WeekLabels.css calendar-7.0.0/src/AgendaView.vala calendar-7.0.0/src/Application.vala calendar-7.0.0/src/EventEdition/EventDialog.vala calendar-7.0.0/src/EventEdition/GuestGrid.vala calendar-7.0.0/src/EventEdition/GuestsPanel.vala calendar-7.0.0/src/EventEdition/InfoPanel.vala calendar-7.0.0/src/EventEdition/LocationPanel.vala calendar-7.0.0/src/EventEdition/ReminderPanel.vala calendar-7.0.0/src/EventEdition/RepeatPanel.vala calendar-7.0.0/src/EventParser/EventParser.vala calendar-7.0.0/src/EventParser/EventParserHandler.vala calendar-7.0.0/src/EventParser/ParsedEvent.vala calendar-7.0.0/src/EventParser/Parsers/ParserDe.vala calendar-7.0.0/src/EventParser/Parsers/ParserEn.vala calendar-7.0.0/src/Grid/CalendarView.vala calendar-7.0.0/src/Grid/EventButton.vala calendar-7.0.0/src/Grid/Grid.vala calendar-7.0.0/src/Grid/GridDay.vala calendar-7.0.0/src/Grid/Header.vala calendar-7.0.0/src/Grid/WeekLabels.vala calendar-7.0.0/src/ImportDialog.vala calendar-7.0.0/src/LanguagesFormat.vala calendar-7.0.0/src/MainWindow.vala calendar-7.0.0/src/SourceDialog/SourceDialog.vala calendar-7.0.0/src/TodayEventMonitor.vala calendar-7.0.0/src/Widgets/AgendaEventRow.vala calendar-7.0.0/src/Widgets/CalendarButton.vala calendar-7.0.0/src/Widgets/CalendarChooser.vala calendar-7.0.0/src/Widgets/CalendarRow.vala calendar-7.0.0/src/Widgets/ConnectivityInfoBar.vala calendar-7.0.0/src/Widgets/ContractorButtonWithMenu.vala calendar-7.0.0/src/Widgets/DateSwitcher.vala calendar-7.0.0/src/Widgets/DateTimePicker.vala calendar-7.0.0/src/Widgets/DynamicSpinner.vala calendar-7.0.0/src/Widgets/EventMenu.vala calendar-7.0.0/src/Widgets/HeaderBar.vala calendar-7.0.0/src/Widgets/SourcePopover.vala calendar-7.0.0/src/Widgets/SourceRow.vala GNU Lesser General Public License v2.1 or later ----------------------------------------------- calendar-7.0.0/src/Grid/VAutoHider.vala GNU Library General Public License v2 or later ---------------------------------------------- calendar-7.0.0/core/Backends/Backend.vala calendar-7.0.0/core/Backends/BackendsManager.vala calendar-7.0.0/core/Backends/LocalBackend.vala calendar-7.0.0/core/Backends/PlacementWidget.vala calendar-7.0.0/plugins/CalDAV/CalDAVBackend.vala calendar-7.0.0/plugins/Google/GoogleBackend.vala
(In reply to Benson Muite from comment #5) > Comments: > a) Svg icons should go into /usr/share/icons/hicolor/scalable No, the image format has no bearing on where those icons should get installed. Most elementary projects provide even the size-specific icons in SVG format instead of in a bitmap format. > b) Builds on all architectures > https://koji.fedoraproject.org/koji/taskinfo?taskID=109417319 > c) Package seems to have additional licenses: Yes, the license tag already reflects this. The license file provided by the project is for GPL-3.0, which is the "effective" license if you combine all these.
>> c) Package seems to have additional licenses: >Yes, the license tag already reflects this. >The license file provided by the project is for GPL-3.0, which is the "effective" license if you combine all these. All relevant licenses in the compiled files need to be indicated. Please see: https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis
(In reply to Benson Muite from comment #7) > >> c) Package seems to have additional licenses: > > >Yes, the license tag already reflects this. > >The license file provided by the project is for GPL-3.0, which is the "effective" license if you combine all these. > > All relevant licenses in the compiled files need to be indicated. Please see: > https://docs.fedoraproject.org/en-US/legal/license-field/ > #_no_effective_license_analysis They are: License: GPL-3.0-or-later AND GPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-2.0-or-later
Copr build: https://copr.fedorainfracloud.org/coprs/build/6726617 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251102-elementary-calendar/fedora-rawhide-x86_64/06726617-elementary-calendar/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-calendar Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Same directory ownership issue as https://bugzilla.redhat.com/show_bug.cgi?id=2251096 otherwise seems ok.
I think we can let that go, given that there's a bug with filesystem to fix it. Co-ownership of locale directories can wind up being problematic, so it's better to avoid it and just prod the filesystem maintainer to add the directories.
Ok. Approved.
Thank you! https://pagure.io/releng/issue/11833
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-046418b8e0