Fedora Merge Review: aspell-br http://cvs.fedora.redhat.com/viewcvs/devel/aspell-br/
build.log showed me word-list-compress d < br.cwl | aspell --lang=br create master ./br.rws Warning: The word "a-zre-'mañ" is invalid. The character '-' (U+2D) must be followed by an alphabetic character. Skipping word. Warning: The word "pont-'n-abad" is invalid. The character '-' (U+2D) must be followed by an alphabetic character. Skipping word. Can you fix this? Also, Can you remove option DESTDIR=$RPM_BUILD_ROOT from ./configure and update SPEC?
DESTDIR option was removed - but there is no need to fix the above warning messages - they does not mean any harm.
Review: + package builds in mock (development i386). - rpmlint is NOT silent for SRPM and RPM. But following messages are ignorable E: aspell-br no-binary E: aspell-br only-non-binary-in-usr-lib E: aspell-br configure-without-libdir-spec + SPEC file contains explanation about above warnings. + source files match upstream. 800c7a28e09bd7734d1501cb7a91ad8f aspell-br-0.50-2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Requires: aspell >= 12:0.60 + Provides: aspell-br = 50:0.50-8.fc7 + Not a GUI APP. APPROVED.
As build is available now, therefore CLOSING this review.