Bug 225266 - Merge Review: aspell-en
Merge Review: aspell-en
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-29 16:04 EST by Nobody's working on this, feel free to take it
Modified: 2010-07-26 18:25 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-10 23:37:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)
Clean SPEC (3.00 KB, application/octet-stream)
2007-03-27 06:31 EDT, Parag AN(पराग)
no flags Details

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-29 16:04:01 EST
Fedora Merge Review: aspell-en

http://cvs.fedora.redhat.com/viewcvs/devel/aspell-en/
Comment 1 Parag AN(पराग) 2007-03-27 06:31:08 EDT
Created attachment 151007 [details]
Clean SPEC 

Update Source to aspell6-en-6.0-0
Comment 2 Parag AN(पराग) 2007-03-30 02:39:14 EDT
rpmlint on SRPM reported
W: aspell-en unversioned-explicit-obsoletes aspell-en-gb
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

W: aspell-en unversioned-explicit-obsoletes aspell-en-ca
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

Can you add versions in Obsoletes tag?

rpmlint on RPM reported
E: aspell-en obsolete-not-provided aspell-en-gb
The obsoleted package must also be provided to allow clean upgrade paths
and not to break dependencies.

E: aspell-en obsolete-not-provided aspell-en-ca
The obsoleted package must also be provided to allow clean upgrade paths
and not to break dependencies.

But as discussed before
https://www.redhat.com/archives/fedora-maintainers/2007-March/msg00463.html

obsolete not provided is Warning and can be ignored.
Comment 3 Ivana Varekova 2007-04-04 06:58:03 EDT
Thanks Parag for your excellent work.
There should be used Conflicts flag instead of Obsoletes (see
http://fedoraproject.org/wiki/PackagingDrafts/Conflicts).
The fixed version is aspell-en-6.0-6.fc7.
Comment 4 Parag AN(पराग) 2007-04-04 08:09:15 EDT
Review:
+ package builds in mock (development i386).
- rpmlint is NOT silent for SRPM and RPM.
  E: aspell-en obsolete-not-provided aspell-en-gb
The obsoleted package must also be provided to allow clean upgrade paths
and not to break dependencies.

E: aspell-en obsolete-not-provided aspell-en-ca
The obsoleted package must also be provided to allow clean upgrade paths
and not to break dependencies.
  
  The above are OK and already set to show warning instead Error in rpmlint CVS.

  Also following messages are ignorable
  E: aspell-en no-binary
  E: aspell-en only-non-binary-in-usr-lib
  E: aspell-en configure-without-libdir-spec
+ SPEC file contains explanation about above warnings.
+ source files match upstream.
16449e0a266e1ecc526b2f3cd39d4bc2  aspell6-en-6.0-0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Requires: aspell >= 12:0.60
+ Provides: aspell-en = 50:6.0-7.fc7
+ Not a GUI APP.
APPROVED.
Comment 5 Parag AN(पराग) 2007-04-04 08:10:09 EDT
Forgot to mention new SPEC contains Obsoletes and not Conflicts
Comment 6 Parag AN(पराग) 2007-04-10 23:37:21 EDT
As build is available now, therefore CLOSING this review.
Comment 7 Paul Howarth 2010-07-08 04:44:24 EDT
I would like to see this package branched for EPEL-6 for reasons described in Bug #590700.

Ivana, would you be willing to maintain this in EPEL-6? If not, I'll be happy to look after it there.
Comment 8 Paul Howarth 2010-07-26 06:57:29 EDT
Package Change Request
======================
Package Name: aspell-en
New Branches: EL-6
Owners: pghmcfc

No response from owner in over 2 weeks; needed for perl-Text-Aspell and all perl modules that depend on it.

I will of course be happy to hand this branch back to Ivana should she want it.
Comment 9 Ivana Varekova 2010-07-26 08:50:56 EDT
Hello, sorry for the late response, , I can finish the process when the branch will be created and maintain the package if it is ok for you. Is it ok for you?
Comment 10 Paul Howarth 2010-07-26 08:58:49 EDT
Ivana, I'm delighted to have you as maintainer - my only interest in the package is that I need it as a dependency of other things. So I'll change the package change request accordingly:

Package Change Request
======================
Package Name: aspell-en
New Branches: EL-6
Owners: varekova
Comment 11 Ivana Varekova 2010-07-26 09:08:18 EDT
Thanks :)
Comment 12 Kevin Fenzi 2010-07-26 18:25:39 EDT
CVS done (by process-cvs-requests.py).

Note You need to log in before you can comment on or make changes to this bug.