Bug 2254622 - Review Request: rust-unicode_names2_generator - Generates the perfect-hash function used by unicode_names2
Summary: Review Request: rust-unicode_names2_generator - Generates the perfect-hash fu...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Aleksei Bavshin
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/unicode_name...
Whiteboard:
Depends On:
Blocks: 2254623
TreeView+ depends on / blocked
 
Reported: 2023-12-14 22:34 UTC by Fabio Valentini
Modified: 2023-12-21 19:48 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-21 19:48:16 UTC
Type: ---
Embargoed:
alebastr89: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-12-14 22:34:30 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-unicode_names2_generator.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-unicode_names2_generator-1.2.1-1.fc39.src.rpm

Description:
Generates the perfect-hash function used by `unicode_names2`.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-12-14 22:34:33 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110348706

Comment 2 Fedora Review Service 2023-12-14 22:43:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6758164
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254622-rust-unicode_names2_generator/fedora-rawhide-x86_64/06758164-rust-unicode_names2_generator/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Aleksei Bavshin 2023-12-21 14:27:55 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2023-12-21 18:51:59 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-12-21 18:52:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unicode_names2_generator

Comment 6 Fedora Update System 2023-12-21 19:45:16 UTC
FEDORA-2023-c11caaa023 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c11caaa023

Comment 7 Fedora Update System 2023-12-21 19:48:16 UTC
FEDORA-2023-c11caaa023 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.