Spec URL: https://decathorpe.fedorapeople.org/rust-unicode_names2.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-unicode_names2-1.2.1-1.fc39.src.rpm Description: Map characters to and from their name given in the Unicode standard. This goes to great lengths to be as efficient as possible in both time and space, with the full bidirectional tables weighing barely 500 KB but still offering O(1)* look-up in both directions. (*more precisely, O(length of name).). Fedora Account System Username: decathorpe
Copr build: https://copr.fedorainfracloud.org/coprs/build/6758167 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254623-rust-unicode_names2/fedora-rawhide-x86_64/06758167-rust-unicode_names2/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # * tests can only be run in-tree > %bcond_with check Tests seem to work with unicode_names2_macros in the buildroot. I haven't noticed anything that depends on the workspace layout. Although I'd accept "don't want to package unicode_names2_macros" as a reason for skipping the tests :) There's an unused python2 (2! that's how I know it's unused) script src/ngrams.py which can be excluded. It doesn't seem to affect rpmbuild output though.
> Tests seem to work with unicode_names2_macros in the buildroot. Right, but unicode_names2_macros depends on unicode2_names. So even if I wanted to package the former to enable tests in the latter, I'd need to to a "bootstrap" build without tests enabled first ;) > There's an unused python2 (2! that's how I know it's unused) script src/ngrams.py which can be excluded. Good catch, I have excluded that file.
(In reply to Fabio Valentini from comment #3) > > Tests seem to work with unicode_names2_macros in the buildroot. > > Right, but unicode_names2_macros depends on unicode2_names. So even if I > wanted to package the former to enable tests in the latter, I'd need to to a > "bootstrap" build without tests enabled first ;) To clarify: Yes, I don't want to package the macros since I don't need them.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is skipped, but the reason is acceptable - latest version of the crate is packaged - license matches upstream specification ((MIT OR Apache-2.0) AND Unicode-DFS-2016) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === > To clarify: Yes, I don't want to package the macros since I don't need them. Fair enough. Consider updating the comment to point to the missing deps and bootstrap.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unicode_names2
FEDORA-2023-c11caaa023 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c11caaa023
FEDORA-2023-c11caaa023 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.