Spec URL: https://cmadams.fedorapeople.org/perl-IO-Async-Loop-Mojo/perl-IO-Async-Loop-Mojo.spec SRPM URL: https://cmadams.fedorapeople.org/perl-IO-Async-Loop-Mojo/perl-IO-Async-Loop-Mojo-0.07-1.fc39.src.rpm Description: This subclass of IO::Async::Loop uses Mojo::Reactor to perform its IO operations. It allows the use of IO::Async-based code or modules from within a Mojolicious application. Fedora Account System Username: cmadams
Taking.
=== KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=111449569 [x] Rpmlint output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s [x] Package is not relocatable. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL-1.0-or-later OR Artistic-1.0-Perl [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc or %license. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. c896f2e3c7821d9518e3fb616ec3da0b IO-Async-Loop-Mojo-0.07.tar.gz Note that http://search.cpan.org/dist/IO-Async-Loop-Mojo/ is a redirect to https://metacpan.org/dist/IO-Async-Loop-Mojo . You should update the URL to the latter. [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?] Reviewer should test that the package builds in mock. Tested on: FIXME [x] Package should compile and build into binary rpms on all supported architectures. Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=111449569 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass Resolution: Approved
Thanks for the review! For this whole batch of perl modules (19 build and/or run deps leading to WWW::Mechanize::Chrome), I started with cpanspec (which is getting pretty out of date I guess) output and then cleaned up the obvious things to a more recent SPEC level. I didn't catch that the URLs bounce through search.cpan.org; I'll change that on all of them.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IO-Async-Loop-Mojo
FEDORA-2024-57f9e70c7f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-57f9e70c7f
FEDORA-2024-57f9e70c7f has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-57f9e70c7f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-57f9e70c7f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-57f9e70c7f has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.