Bug 2254927 - Review Request: perl-Future-Mojo - Use Future with Mojo::IOLoop
Summary: Review Request: perl-Future-Mojo - Use Future with Mojo::IOLoop
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2254916
Blocks: 2254933
TreeView+ depends on / blocked
 
Reported: 2023-12-17 22:52 UTC by Chris Adams
Modified: 2024-03-30 01:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-29 04:10:30 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Chris Adams 2023-12-17 22:52:55 UTC
Spec URL: https://cmadams.fedorapeople.org/perl-Future-Mojo/perl-Future-Mojo.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Future-Mojo/perl-Future-Mojo-1.002-1.fc39.src.rpm
Description:
This subclass of Future stores a reference to the associated Mojo::IOLoop
instance, allowing the await method to block until the Future is ready.

Fedora Account System Username: cmadams

Comment 1 Chris Adams 2023-12-17 22:53:25 UTC
Note: depends on perl-IO-Async-Loop-Mojo (review BZ 2254916)

Comment 5 Petr Pisar 2024-03-21 10:11:20 UTC
URL and Source0 addresses are usable. Ok.
TODO: Remove a trailing slash from the URL tag value.

Source0 archive (SHA512: 324255b6a6c625d5e92d39b464bc46c34c6a3f1d7f8a837863fc98daf0aa367fb57a89b9e4940e1b3f7c923ecae90576e8fd2d479e0eea67a691ba60a25983e3) is original. Ok.
Summary verified from lib/Future/Mojo.pm. Ok.
Description verified from lib/Future/Mojo.pm. Ok.
License found in the sources:

Artistic-2.0: README, LICENSE, dist.ini, lib/Future/Mojo.pm, lib/Future/Role/Promisify.pm.
"Based on CC0-1.0": CONTRIBUTING.md
Note: I will handle CONTRIBUTING.md as licensed under Artistic-2.0 since "Based on CC0-1.0" does not imply CC0-1.0. I hope my interpretation is correct. Otherwise, that file should be stripped from the sources archive because Fedora does on accept CC0-1.0 for a documentation.
License is Ok.

No XS code, noarch BuildArch is Ok.

TODO: Build-require "perl(:VERSION) >= 5.10.1" (Build.PL:21).
FIX: Do not build-require "perl(Module::Build)". It's not (directly) used if "perl(Module::Build::Tiny) >= 0.034" is available.
TODO: Constrain "perl(IO::Async::Loop)" dependency with ">= 0.56" (t/promisify.t:63).
TODO: Constrain "perl(IO::Async::Loop::Mojo)" dependency with ">= 0.04" (t/promisify.t:63).

All tests pass. Ok.

$ rpmlint perl-Future-Mojo.spec ../SRPMS/perl-Future-Mojo-1.002-4.fc41.src.rpm ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Future-Mojo.noarch: E: spelling-error ('IOLoop', 'Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop')
perl-Future-Mojo.noarch: E: spelling-error ('IOLoop', '%description -l en_US IOLoop -> Io Loop, Io-loop, Loop')
perl-Future-Mojo.src: E: spelling-error ('IOLoop', 'Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop')
perl-Future-Mojo.src: E: spelling-error ('IOLoop', '%description -l en_US IOLoop -> Io Loop, Io-loop, Loop')
=== 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.4 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/doc/perl-Future-Mojo
-rw-r--r--    1 root     root                     4461 Jun 16  2021 /usr/share/doc/perl-Future-Mojo/CONTRIBUTING.md
-rw-r--r--    1 root     root                      784 Jun 16  2021 /usr/share/doc/perl-Future-Mojo/Changes
-rw-r--r--    1 root     root                     2600 Jun 16  2021 /usr/share/doc/perl-Future-Mojo/README
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/licenses/perl-Future-Mojo
-rw-r--r--    1 root     root                     9037 Jun 16  2021 /usr/share/licenses/perl-Future-Mojo/LICENSE
-rw-r--r--    1 root     root                     1858 Mar  8 01:00 /usr/share/man/man3/Future::Mojo.3pm.gz
-rw-r--r--    1 root     root                     1841 Mar  8 01:00 /usr/share/man/man3/Future::Role::Promisify.3pm.gz
-rw-r--r--    1 root     root                     4244 Jun 16  2021 /usr/share/perl5/vendor_perl/Future/Mojo.pm
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/perl5/vendor_perl/Future/Role
-rw-r--r--    1 root     root                     2600 Jun 16  2021 /usr/share/perl5/vendor_perl/Future/Role/Promisify.pm
TODO: Do not package CONTRIBUTING.md. It assumes you already have the sources available. This is not the case of a binary package. And if you obtain a source package, then you have CONTRIBUTING.md there. Moreover, that file does not bring any helpful information for using the packaged software.
TODO: Package %{perl_vendorlib}/Future directory.

$ rpm -q --requires -p ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(Carp)
      1 perl(Future)
      1 perl(Mojo::IOLoop)
      1 perl(Mojo::Promise)
      1 perl(parent)
      1 perl(Role::Tiny)
      1 perl(Role::Tiny::With)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Constrain "perl(Future)" with ">= 0.36" (META.json:44).
TODO: Constrain "perl(Role::Tiny)" with ">= 2.000002" (META.json:45).
FIX: Run-require "perl-Mojolicious >= 7.54" or "perl(Mojolicious) >= 7.54" (META.json:45). That module is not directly used, but it's the only versioned module in perl-Mojolicious RPM package. The minimal version is required because of perl(Mojo::IOLoop) and perl(Mojo::Promise) which are unversioned.

$ rpm -q --provides -p ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(Future::Mojo) = 1.002
      1 perl(Future::Role::Promisify) = 1.002
      1 perl-Future-Mojo = 1.002-4.fc41
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Future-Mojo-1.002-4.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=115241331). Ok.

TODO: Consider upgrading the package the the latest upstream release (1.003).

Otherwise the package in line with Fedora and Perl packaging guidelines.
Please correct the FIX items, consider fixing the TODO items and provide an updated spec file.

Comment 6 Chris Adams 2024-03-21 13:47:36 UTC
Bumped release for new upstream version and additional spec file cleanups:
Spec URL: https://cmadams.fedorapeople.org/perl-Future-Mojo/perl-Future-Mojo.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Future-Mojo/perl-Future-Mojo-1.003-1.fc39.src.rpm

Comment 7 Petr Pisar 2024-03-21 16:08:02 UTC
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA512: a81cd1d7373388dd7677f8b1ff1b7350d4b57dc7ab3cb90c5529d7e3f1c793696773c829b86780338e8632fdcc34ae17af50f19191a32ae9f6d4f874e8703e8e) is original. Ok.
License verified from a difference between Future-Mojo-1.00{2,3}. Ok.
All tests pass. Ok.

$ rpmlint perl-Future-Mojo.spec ../SRPMS/perl-Future-Mojo-1.003-1.fc41.src.rpm ../RPMS/noarch/perl-Future-Mojo-1.003-1.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Future-Mojo.noarch: E: spelling-error ('IOLoop', 'Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop')
perl-Future-Mojo.noarch: E: spelling-error ('IOLoop', '%description -l en_US IOLoop -> Io Loop, Io-loop, Loop')
perl-Future-Mojo.src: E: spelling-error ('IOLoop', 'Summary(en_US) IOLoop -> Io Loop, Io-loop, Loop')
perl-Future-Mojo.src: E: spelling-error ('IOLoop', '%description -l en_US IOLoop -> Io Loop, Io-loop, Loop')
=== 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.5 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Future-Mojo-1.003-1.fc41.noarch.rpm
drwxr-xr-x    2 root     root                        0 Mar 21 01:00 /usr/share/doc/perl-Future-Mojo
-rw-r--r--    1 root     root                      897 Mar 11 05:28 /usr/share/doc/perl-Future-Mojo/Changes
-rw-r--r--    1 root     root                     2600 Mar 11 05:28 /usr/share/doc/perl-Future-Mojo/README
drwxr-xr-x    2 root     root                        0 Mar 21 01:00 /usr/share/licenses/perl-Future-Mojo
-rw-r--r--    1 root     root                     9037 Mar 11 05:28 /usr/share/licenses/perl-Future-Mojo/LICENSE
-rw-r--r--    1 root     root                     1858 Mar 21 01:00 /usr/share/man/man3/Future::Mojo.3pm.gz
-rw-r--r--    1 root     root                     1842 Mar 21 01:00 /usr/share/man/man3/Future::Role::Promisify.3pm.gz
drwxr-xr-x    2 root     root                        0 Mar 21 01:00 /usr/share/perl5/vendor_perl/Future
-rw-r--r--    1 root     root                     4274 Mar 11 05:28 /usr/share/perl5/vendor_perl/Future/Mojo.pm
drwxr-xr-x    2 root     root                        0 Mar 21 01:00 /usr/share/perl5/vendor_perl/Future/Role
-rw-r--r--    1 root     root                     2600 Mar 11 05:28 /usr/share/perl5/vendor_perl/Future/Role/Promisify.pm
The file layout and permission are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Future-Mojo-1.003-1.fc41.noarch.rpm | sort -f | uniq -c 
      1 perl(Carp)
      1 perl(Future)
      1 perl(Future) >= 0.49
      1 perl(Mojo::IOLoop)
      1 perl(Mojo::Promise)
      1 perl(Mojolicious) >= 7.54
      1 perl(parent)
      1 perl(Role::Tiny)
      1 perl(Role::Tiny) >= 2.000002
      1 perl(Role::Tiny::With)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Filter the under-specified dependencies: perl(Future), perl(Role::Tiny).

$ rpm -q --provides -p ../RPMS/noarch/perl-Future-Mojo-1.003-1.fc41.noarch.rpm | sort -f | uniq -c 
      1 perl(Future::Mojo) = 1.003
      1 perl(Future::Role::Promisify) = 1.003
      1 perl-Future-Mojo = 1.003-1.fc41
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Future-Mojo-1.003-1.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=115254259). Ok.

Please consider fixing the TODO item before building this package.
This package is APPROVED.

Comment 8 Fedora Admin user for bugzilla script actions 2024-03-21 16:37:38 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Future-Mojo

Comment 9 Fedora Update System 2024-03-21 17:08:00 UTC
FEDORA-2024-4ceadd90be (perl-Future-Mojo-1.003-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ceadd90be

Comment 10 Fedora Update System 2024-03-21 17:15:55 UTC
FEDORA-2024-9f8583a608 (perl-Future-Mojo-1.003-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f8583a608

Comment 11 Fedora Update System 2024-03-22 02:09:20 UTC
FEDORA-2024-9f8583a608 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9f8583a608 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f8583a608

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-03-22 02:35:30 UTC
FEDORA-2024-4ceadd90be has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4ceadd90be \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ceadd90be

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-03-29 04:10:30 UTC
FEDORA-2024-9f8583a608 (perl-Future-Mojo-1.003-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-03-30 01:09:16 UTC
FEDORA-2024-4ceadd90be (perl-Future-Mojo-1.003-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.