Bug 2255630 - Review Request: asio-grpc - Asynchronous gRPC with Asio/unified executors
Summary: Review Request: asio-grpc - Asynchronous gRPC with Asio/unified executors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Onuralp Sezer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2255633
TreeView+ depends on / blocked
 
Reported: 2023-12-22 15:18 UTC by Tom "spot" Callaway
Modified: 2023-12-31 02:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-31 01:19:31 UTC
Type: ---
Embargoed:
thunderbirdtr: fedora-review+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2023-12-22 15:18:42 UTC
Spec URL: https://spot.fedorapeople.org/asio-grpc.spec
SRPM URL: https://spot.fedorapeople.org/asio-grpc-2.8.0-1.fc40.src.rpm
Description: 
An Executor, Networking TS and std::execution interface to
grpc::CompletionQueue for writing asynchronous gRPC clients and servers using
C++20 coroutines, Boost.Coroutines, Asio's stackless coroutines, callbacks,
sender/receiver and more.
Fedora Account System Username: spot
Koji Rawhide Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110698473

This is a very straightforward header-only noarch package that extends grpc. It is needed for newer versions of Cura.

Comment 1 Onuralp Sezer 2023-12-22 15:49:44 UTC
I am taking this review

Comment 2 Onuralp Sezer 2023-12-22 15:51:15 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing looks correct
* No serious issues in rpmlint

Everything looks good.

PACKAGE APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-12-22 15:58:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/asio-grpc

Comment 4 Fedora Update System 2023-12-22 16:26:37 UTC
FEDORA-2023-88ffd517b6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-88ffd517b6

Comment 5 Fedora Update System 2023-12-22 16:26:37 UTC
FEDORA-2023-9fde1a5c50 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9fde1a5c50

Comment 6 Fedora Update System 2023-12-23 04:56:32 UTC
FEDORA-2023-9fde1a5c50 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9fde1a5c50 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9fde1a5c50

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-12-23 05:14:16 UTC
FEDORA-2023-88ffd517b6 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-88ffd517b6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-88ffd517b6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-12-31 01:19:31 UTC
FEDORA-2023-88ffd517b6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-12-31 02:27:07 UTC
FEDORA-2023-9fde1a5c50 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.