Bug 2255633 - Review Request: CuraEngine_grpc_definitions - gRPC Proto Definitions for CuraEngine
Summary: Review Request: CuraEngine_grpc_definitions - gRPC Proto Definitions for Cura...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Onuralp Sezer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2255630
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-22 15:36 UTC by Tom "spot" Callaway
Modified: 2023-12-31 02:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-31 01:19:38 UTC
Type: ---
Embargoed:
thunderbirdtr: fedora-review+

Attachments (Terms of Use)

Description Tom "spot" Callaway 2023-12-22 15:36:14 UTC 
Spec URL: https://spot.fedorapeople.org/CuraEngine_grpc_definitions.spec
SRPM URL: https://spot.fedorapeople.org/CuraEngine_grpc_definitions-0.1.0-1.fc40.src.rpm
Description: 
This package contains the gRPC proto definitions for CuraEngine. These
definitions are used to generate the gRPC code for the CuraEngine gRPC
plugin system.
Fedora Account System Username: spot

CuraEngine grew this grpc proto system as part of adding plugin support. I need this new package to update CuraEngine, which is needed for newer versions of Cura.

It depends on asio-grpc, which is pending review as bz#2255630

A scratch build for this exists in my copr (which also has asio-grpc in it):
https://copr.fedorainfracloud.org/coprs/spot/cura/build/6783956/
Comment 1 Onuralp Sezer 2023-12-22 15:52:31 UTC 
I am taking this review
Comment 2 Onuralp Sezer 2023-12-22 15:53:21 UTC 
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing looks correct
* No serious issues in rpmlint

Everything looks good.

PACKAGE APPROVED.
Comment 3 Fedora Admin user for bugzilla script actions 2023-12-22 15:59:27 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/CuraEngine_grpc_definitions
Comment 4 Fedora Update System 2023-12-22 22:48:15 UTC 
FEDORA-2023-37a8e93b79 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-37a8e93b79
Comment 5 Fedora Update System 2023-12-23 04:56:37 UTC 
FEDORA-2023-e2780775fa has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e2780775fa \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e2780775fa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 6 Fedora Update System 2023-12-23 05:14:20 UTC 
FEDORA-2023-37a8e93b79 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-37a8e93b79 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-37a8e93b79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 7 Fedora Update System 2023-12-31 01:19:38 UTC 
FEDORA-2023-37a8e93b79 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 Fedora Update System 2023-12-31 02:27:11 UTC 
FEDORA-2023-e2780775fa has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.