Bug 2257186 - Review Request: rust-selinux-sys - Flexible Mandatory Access Control (MAC) for Linux
Summary: Review Request: rust-selinux-sys - Flexible Mandatory Access Control (MAC) fo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2257190
TreeView+ depends on / blocked
 
Reported: 2024-01-07 21:03 UTC by Michel Lind
Modified: 2024-01-18 01:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-12 18:48:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-01-07 21:03:23 UTC
Spec URL: https://salimma.fedorapeople.org/rust-selinux-sys.spec
SRPM URL: https://salimma.fedorapeople.org/rust-selinux-sys-0.6.7-1.fc38.src.rpm

Description:
Flexible Mandatory Access Control (MAC) for Linux.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2024-01-08 19:44:03 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- generated files are re-generated unconditionally
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

I would recommend to drop the "static" feature from this package. I doubt that it would even work.

Comment 2 Fedora Admin user for bugzilla script actions 2024-01-09 01:08:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-selinux-sys

Comment 3 Michel Lind 2024-01-09 01:19:23 UTC
Thank you! confirmed that after dropping the static feature (in rust2rpm.toml) I can still build rust-selinux against it

Comment 4 Fedora Update System 2024-01-09 03:11:47 UTC
FEDORA-2024-0047d8edd8 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0047d8edd8

Comment 5 Fedora Update System 2024-01-09 03:11:48 UTC
FEDORA-2024-b57906a84a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b57906a84a

Comment 6 Fedora Update System 2024-01-10 01:48:03 UTC
FEDORA-2024-0047d8edd8 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0047d8edd8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0047d8edd8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-01-10 01:57:51 UTC
FEDORA-2024-b57906a84a has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b57906a84a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b57906a84a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-01-18 01:24:57 UTC
FEDORA-2024-b57906a84a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-01-18 01:45:23 UTC
FEDORA-2024-0047d8edd8 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.