Red Hat Bugzilla – Bug 225731
Merge Review: epic
Last modified: 2015-07-15 11:26:43 EDT
Fedora Merge Review: epic
Initial Owner: firstname.lastname@example.org
formal review of epic-2.10-6.fc12 is here, see the notes below:
YES source files match upstream:
YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros consistently.
YES dist tag is present.
YES build root is correct.
YES license field matches the actual license.
YES license is open source-compatible.
YES License text included in package.
NO latest version is being packaged.
epic4-2.10.1.tar.bz2 was released 09/05/2009
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES %clean is present.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.
NO rpmlint is silent.
>rpmlint epic-2.10-6.fc12.src.rpm epic-2.10-6.fc12.x86_64.rpm
epic.x86_64: E: file-in-usr-marked-as-conffile /usr/share/epic/ircII.servers
epic.x86_64: E: zero-length /usr/share/epic/help/8_Scripts/nopaste
epic.x86_64: E: zero-length /usr/share/epic/help/8_Scripts/mkpdir
epic.x86_64: E: non-executable-script /usr/share/epic/script/epic-crypt-gpg-aa 0644 /bin/bash
epic.x86_64: E: non-executable-script /usr/share/epic/script/epic-crypt-gpg 0644 /bin/bash
epic.x86_64: W: file-not-utf8 /usr/share/doc/epic-2.10/COPYRIGHT
epic.x86_64: E: script-without-shebang /usr/share/epic/help/5_Programming/fec
epic.x86_64: E: executable-marked-as-config-file /usr/share/epic/ircII.servers
epic.x86_64: E: script-without-shebang /usr/share/epic/ircII.servers
2 packages and 0 specfiles checked; 87 errors, 1 warnings.
YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
?? file permissions are appropriate.
See some rpmlint errors.
YES scriptlets are sane.
YES code, not content.
YES documentation is small, so no -docs subpackage is necessary.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.
Please look at the rpmlint errors and either fix them or confirm they are false positives.
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket:
If you don't know what merge reviews are about, please see:
How to handle this bug is left to the discretion of the package maintainer.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.
(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)
More information and reason for this action is here: