Fedora Merge Review: ftp http://cvs.fedora.redhat.com/viewcvs/devel/ftp/ Initial Owner: mmaslano
* RPM name is OK * Source netkit-ftp-0.17.tar.bz2 is the same as upstream * Builds fine in mock * File list looks OK rpmlint is not silent: Source RPM: W: ftp summary-ended-with-dot The standard UNIX FTP (File Transfer Protocol) client. W: ftp no-url-tag W: ftp hardcoded-path-in-buildroot-tag /var/tmp/%{name}-root Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gcc should not be included (wiki: PackagingGuidelines#Exceptions) * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Your debuginfo package is empty. This is because binaries are installed with install -s * You're missing the URL tag
Thanks for review. No upstream -> no url tag.
This looks much better! A few details: * Remove the commented out BuildRoot, rpmlint complains about it * Preserve timestamps when installing files (use install -p or cp -p)
Ok, I made another changes.
The upstream tarball for netkit-ftp is a gzipped file, not bzipped. netkit-ftp-0.17 isn't available anymore on ftp://ftp.uk.linux.org/pub/linux/Networking/netkit-devel So you could either update to netkit-ftp-0.18-pre1 or change the Source0 url
I don't want to add new version to FC-7. It's "only" pre- version. It should stay in devel some time for testing.
Ok, then please change the Source0 url to the correct source.
Now I have Source0: ftp://ftp.uk.linux.org/pub/linux/Networking/netkit/netkit-ftp-%{version}.tar.gz
Thanks. I don't see any further blockers so this package is approved.