Bug 225774 - Merge Review: ftp
Merge Review: ftp
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Package Reviews List
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 13:40 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-20 03:52:58 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:40:29 EST
Fedora Merge Review: ftp

http://cvs.fedora.redhat.com/viewcvs/devel/ftp/
Initial Owner: mmaslano@redhat.com
Comment 1 Ruben Kerkhof 2007-02-03 11:27:20 EST
* RPM name is OK
* Source netkit-ftp-0.17.tar.bz2 is the same as upstream
* Builds fine in mock
* File list looks OK

rpmlint is not silent:
Source RPM:
W: ftp summary-ended-with-dot The standard UNIX FTP (File Transfer Protocol) client.
W: ftp no-url-tag
W: ftp hardcoded-path-in-buildroot-tag /var/tmp/%{name}-root

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* BuildRequires: gcc should not be included
  (wiki: PackagingGuidelines#Exceptions)
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Your debuginfo package is empty. This is because binaries are installed with install -s
* You're missing the URL tag




Comment 2 Marcela Mašláňová 2007-02-06 03:21:53 EST
Thanks for review. 
No upstream -> no url tag.
Comment 3 Ruben Kerkhof 2007-02-06 14:34:59 EST
This looks much better!

A few details:

* Remove the commented out BuildRoot, rpmlint complains about it
* Preserve timestamps when installing files (use install -p or cp -p)

Comment 4 Marcela Mašláňová 2007-02-07 05:45:20 EST
Ok, I made another changes.
Comment 5 Ruben Kerkhof 2007-02-10 07:00:05 EST
The upstream tarball for netkit-ftp is a gzipped file, not bzipped. netkit-ftp-0.17 isn't available anymore 
on ftp://ftp.uk.linux.org/pub/linux/Networking/netkit-devel

So you could either update to netkit-ftp-0.18-pre1 or change the Source0 url
Comment 6 Marcela Mašláňová 2007-02-14 05:25:50 EST
I don't want to add new version to FC-7. It's "only" pre- version. It should
stay in devel some time for testing.
Comment 7 Ruben Kerkhof 2007-02-14 10:32:01 EST
Ok, then please change the Source0 url to the correct source.
Comment 8 Marcela Mašláňová 2007-02-21 13:43:34 EST
Now I have

Source0:
ftp://ftp.uk.linux.org/pub/linux/Networking/netkit/netkit-ftp-%{version}.tar.gz
Comment 9 Ruben Kerkhof 2007-02-21 17:56:36 EST
Thanks.

I don't see any further blockers so this package is approved.

Note You need to log in before you can comment on or make changes to this bug.