Spec URL: https://salimma.fedorapeople.org/specs/rust-argon2.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-argon2-0.5.2-1.fc38.src.rpm Description: Pure Rust implementation of the Argon2 password hashing function with support for the Argon2d, Argon2i, and Argon2id algorithmic variants. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/6913614 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258880-rust-argon2/fedora-rawhide-x86_64/06913614-rust-argon2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two issues: 1. The summary is *way too long*, please trim it in the package and in this bug's title. 2. Using ExcludeArch is a very big hammer and should almost *never* be done for library-only crates, since it will prevent dependent packages from building on this architecture as well. In this case, please report an issue with the upstream project. The RustCrypto people are very pleasant to work with, in my experience. It might just be that the test fixtures assume little-endian byte order, or it might be that the code is actually broken on big-endian architectures. Either would be good to know.
Makes sense, thanks. I'll just disable tests on s390x for now and file the issue upstream
Filed https://github.com/RustCrypto/password-hashes/issues/481 and updated the spec and SRPM [fedora-review-service-build]
Created attachment 2009347 [details] The .spec file difference from Copr build 6913614 to 6923231
Copr build: https://copr.fedorainfracloud.org/coprs/build/6923231 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258880-rust-argon2/fedora-rawhide-x86_64/06923231-rust-argon2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Upstream has fixed the big-endian support and released a new version - can you update this package? https://github.com/RustCrypto/password-hashes/blob/master/argon2/CHANGELOG.md