Bug 2258880 - Review Request: rust-argon2 - Pure Rust implementation of the Argon2 password hashing function
Summary: Review Request: rust-argon2 - Pure Rust implementation of the Argon2 password...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/argon2
Whiteboard:
Depends On:
Blocks: 2283849
TreeView+ depends on / blocked
 
Reported: 2024-01-17 21:17 UTC by Michel Lind
Modified: 2024-07-07 00:39 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-07-03 19:41:28 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6913614 to 6923231 (1.05 KB, patch)
2024-01-19 21:11 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 6923231 to 7673137 (614 bytes, patch)
2024-06-26 23:18 UTC, Fedora Review Service
no flags Details | Diff

Description Michel Lind 2024-01-17 21:17:30 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-argon2.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-argon2-0.5.2-1.fc38.src.rpm

Description:
Pure Rust implementation of the Argon2 password hashing function with
support for the Argon2d, Argon2i, and Argon2id algorithmic variants.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-17 21:26:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6913614
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258880-rust-argon2/fedora-rawhide-x86_64/06913614-rust-argon2/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-18 19:52:49 UTC
Two issues:

1. The summary is *way too long*, please trim it in the package and in this bug's title.

2. Using ExcludeArch is a very big hammer and should almost *never* be done for library-only crates, since it will prevent dependent packages from building on this architecture as well. In this case, please report an issue with the upstream project. The RustCrypto people are very pleasant to work with, in my experience. It might just be that the test fixtures assume little-endian byte order, or it might be that the code is actually broken on big-endian architectures. Either would be good to know.

Comment 3 Michel Lind 2024-01-19 20:46:32 UTC
Makes sense, thanks. I'll just disable tests on s390x for now and file the issue upstream

Comment 4 Michel Lind 2024-01-19 21:01:48 UTC
Filed https://github.com/RustCrypto/password-hashes/issues/481 and updated the spec and SRPM

[fedora-review-service-build]

Comment 5 Fedora Review Service 2024-01-19 21:11:08 UTC
Created attachment 2009347 [details]
The .spec file difference from Copr build 6913614 to 6923231

Comment 6 Fedora Review Service 2024-01-19 21:11:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6923231
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258880-rust-argon2/fedora-rawhide-x86_64/06923231-rust-argon2/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2024-01-25 22:22:00 UTC
Upstream has fixed the big-endian support and released a new version - can you update this package?
https://github.com/RustCrypto/password-hashes/blob/master/argon2/CHANGELOG.md

Comment 8 Robert-André Mauchin 🐧 2024-06-02 11:00:14 UTC
Assuming you bump the package to the latest version and restore the normal checks:

Rust Package Review

This package was generated using rust2rpm, which simplifies the review.

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

    [!] The latest version is packaged or packaging an earlier version is justified.
    [x] The License tag reflects the package contents and uses the correct identifiers.
    [x] The package builds successfully in mock.
    [x] Package is installable (checked by fedora-review).
    [x] There are no relevant rpmlint errors.
    [x] The package runs tests in %check.
    [x] The package's binaries don't conflict with binaries already in the distribution.
    [x] There are no %{_bindir}/* wildcards in %files.
    [x] The package complies with the Rust and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

    [ ] Add the package to release-monitoring.org
    [ ] Add the package to Koschei
    [ ] Give rust-sig privileges (at least commit) on the package
    [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 9 Michel Lind 2024-06-26 22:36:58 UTC
This probably should not be marked as POST huh

Comment 10 Michel Lind 2024-06-26 23:06:17 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-argon2.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-argon2-0.5.3-1.fc40.src.rpm

summary shortened, tests reenabled on all platforms

Comment 11 Fedora Review Service 2024-06-26 23:18:20 UTC
Created attachment 2038340 [details]
The .spec file difference from Copr build 6923231 to 7673137

Comment 12 Fedora Review Service 2024-06-26 23:18:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7673137
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258880-rust-argon2/fedora-rawhide-x86_64/07673137-rust-argon2/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 13 Michel Lind 2024-07-01 17:34:43 UTC
This was generated straight with rust2rpm, with this rust2rpm.toml

[package]
# original summary too long
summary = "Pure Rust implementation of the Argon2 password hashing function"

Comment 14 Fabio Valentini 2024-07-03 16:57:08 UTC
Package was generated with rust2rpm, simplifying the review.

βœ… package contains only permissible content
βœ… package builds and installs without errors on rawhide
βœ… test suite is run and all unit tests pass
βœ… latest version of the crate is packaged
βœ… license matches upstream specification and is acceptable for Fedora
βœ… license files are included with %license in %files
βœ… package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 15 Michel Lind 2024-07-03 19:22:25 UTC
Thanks!

Comment 16 Fedora Admin user for bugzilla script actions 2024-07-03 19:23:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-argon2

Comment 17 Fedora Update System 2024-07-03 19:39:13 UTC
FEDORA-2024-36a4a9743b (rust-argon2-0.5.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-36a4a9743b

Comment 18 Fedora Update System 2024-07-03 19:41:28 UTC
FEDORA-2024-36a4a9743b (rust-argon2-0.5.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2024-07-03 21:25:37 UTC
FEDORA-EPEL-2024-f879eb60f9 (rust-argon2-0.5.3-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f879eb60f9

Comment 20 Fedora Update System 2024-07-03 21:25:38 UTC
FEDORA-2024-08a90622e0 (rust-argon2-0.5.3-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-08a90622e0

Comment 21 Fedora Update System 2024-07-04 01:59:15 UTC
FEDORA-2024-0b38e08abe has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0b38e08abe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0b38e08abe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 22 Fedora Update System 2024-07-04 02:02:29 UTC
FEDORA-2024-08a90622e0 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-08a90622e0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-08a90622e0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Fedora Update System 2024-07-04 02:10:50 UTC
FEDORA-EPEL-2024-f879eb60f9 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-f879eb60f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Fedora Update System 2024-07-06 07:08:29 UTC
FEDORA-2024-0b38e08abe (rust-argon2-0.5.3-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 25 Fedora Update System 2024-07-06 07:44:09 UTC
FEDORA-2024-08a90622e0 (rust-argon2-0.5.3-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 26 Fedora Update System 2024-07-07 00:39:29 UTC
FEDORA-EPEL-2024-f879eb60f9 (rust-argon2-0.5.3-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.