Bug 2283849 - Review Request: rust-rusty_paserk - Platform Agnostic Serializable Keys
Summary: Review Request: rust-rusty_paserk - Platform Agnostic Serializable Keys
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rusty_paserk
Whiteboard:
Depends On: 2258880 2283850
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-29 18:11 UTC by Cristian Le
Modified: 2024-07-05 11:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-05 11:02:27 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Cristian Le 2024-05-29 18:11:08 UTC
Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/3c3f0e08e67ae68a9b35168a1ccf1dd549dd9aee/rust-rusty_paserk/rust-rusty_paserk.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_parserk-paseto-rpmspec-main/fedora-rawhide-x86_64/07504902-rust-rusty_paserk/rust-rusty_paserk-0.4.0-1.fc41.src.rpm
Description: Dependency for `atuin`
Fedora Account System Username: lecris

rust2rpm.toml
```toml
[[package.extra-patches]]
comments = [
    "Relax libtest-mimic dependency",
]
file = "rust-rusty_paserk-0.4.0-Relax_dependencies.diff"
number = 10
```

Comment 1 Fedora Review Service 2024-05-29 18:13:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7504972
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283849-rust-rusty_paserk/fedora-rawhide-x86_64/07504972-rust-rusty_paserk/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Robert-André Mauchin 🐧 2024-06-02 13:11:38 UTC
 - use rust2rpm -p and document the patch


# Manually created patch for downstream crate metadata changes
# * Relax libtest-mimic dependency
Patch:          rusty_paserk-fix-metadata.diff
# Manually created patch for downstream crate metadata changes
# * Relax libtest-mimic dependency
Patch:          rusty_paserk-fix-metadata.diff


--- rusty_paserk-0.4.0/Cargo.toml	1970-01-01T00:00:01+00:00
+++ rusty_paserk-0.4.0/Cargo.toml	2024-06-02T05:51:42.204196+00:00
@@ -141,7 +141,7 @@
 version = "0.4"
 
 [dev-dependencies.libtest-mimic]
-version = "0.7.3"
+version = ">=0.6.1"
 
 [dev-dependencies.rand]
 version = "0.8"



Rust Package Review

This package was generated using rust2rpm, which simplifies the review.

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

    [x] The latest version is packaged or packaging an earlier version is justified.
    [x] The License tag reflects the package contents and uses the correct identifiers.
    [x] The package builds successfully in mock.
    [x] Package is installable (checked by fedora-review).
    [x] There are no relevant rpmlint errors.
    [x] The package runs tests in %check.
    [x] The package's binaries don't conflict with binaries already in the distribution.
    [x] There are no %{_bindir}/* wildcards in %files.
    [x] The package complies with the Rust and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

    [ ] Add the package to release-monitoring.org
    [ ] Add the package to Koschei
    [ ] Give rust-sig privileges (at least commit) on the package
    [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-05 10:05:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rusty_paserk

Comment 5 Fedora Update System 2024-07-05 10:59:41 UTC
FEDORA-2024-ce52986ef5 (rust-rusty_paserk-0.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ce52986ef5

Comment 6 Fedora Update System 2024-07-05 11:02:27 UTC
FEDORA-2024-ce52986ef5 (rust-rusty_paserk-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.