Bug 2259758 - Review Request: rust-zopfli - Rust implementation of the Zopfli compression algorithm
Summary: Review Request: rust-zopfli - Rust implementation of the Zopfli compression a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/zopfli
Whiteboard:
Depends On:
Blocks: 2259760
TreeView+ depends on / blocked
 
Reported: 2024-01-23 00:12 UTC by Ben Beasley
Modified: 2024-02-18 01:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-08 17:40:55 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-01-23 00:12:34 UTC
Spec URL: https://music.fedorapeople.org/rust-zopfli.spec
SRPM URL: https://music.fedorapeople.org/rust-zopfli-0.8.0-1.fc39.src.rpm

Description:

A Rust implementation of the Zopfli compression algorithm.

Fedora Account System Username: music

PR to be merged after unretirement:
https://src.fedoraproject.org/rpms/rust-zopfli/pull-request/1

Knowing this is sometimes a problem, I will check the changelog of the unretired package and make sure it is not broken.

To avoid packaging the nightly feature, I used (and would commit) the following rust2rpm.toml:

  [features]
  hide = [
    "nightly"
  ]

While I don’t intend to package the zopfli executable from this crate because it has the same name as the one from the zopfli package, packaging this library would allow unretiring and updating https://src.fedoraproject.org/rpms/rust-oxipng, which does provide a useful command-line tool.

Comment 1 Fedora Review Service 2024-01-23 00:20:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6941969
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259758-rust-zopfli/fedora-rawhide-x86_64/06941969-rust-zopfli/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-zopfli
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-23 21:43:58 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

(skip the ones that are not relevant to unretirements)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Before importing and building the package, please make sure to exclude some unnecessary files from the package (i.e. Makefile and rustfmt.toml). You can either use something like `%exclude %{crate_instdir}/Makefile`, or extend the "exclude" setting in Cargo.toml to `exclude = ["test/*", "/Makefile", "/rustfmt.toml"]`.

Comment 3 Ben Beasley 2024-01-23 22:39:14 UTC
Thank you for the review!

Comment 4 Ben Beasley 2024-01-24 15:10:22 UTC
Unretirement requested: https://pagure.io/releng/issue/11911

Comment 5 Fedora Update System 2024-02-08 17:39:12 UTC
FEDORA-2024-4f25552e4f (rust-zopfli-0.8.0-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f25552e4f

Comment 6 Fedora Update System 2024-02-08 17:40:55 UTC
FEDORA-2024-4f25552e4f (rust-zopfli-0.8.0-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-02-08 17:59:32 UTC
FEDORA-2024-ca038edfdd (rust-zopfli-0.8.0-2.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ca038edfdd

Comment 8 Fedora Update System 2024-02-09 01:40:07 UTC
FEDORA-2024-ca038edfdd has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ca038edfdd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ca038edfdd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-02-09 01:44:42 UTC
FEDORA-2024-67faff630e (rust-zopfli-0.8.0-2.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-67faff630e

Comment 10 Fedora Update System 2024-02-10 03:56:04 UTC
FEDORA-2024-67faff630e has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-67faff630e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-67faff630e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-02-17 00:57:26 UTC
FEDORA-2024-ca038edfdd (rust-zopfli-0.8.0-2.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-02-18 01:49:43 UTC
FEDORA-2024-67faff630e (rust-zopfli-0.8.0-2.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.