Spec URL: https://music.fedorapeople.org/rust-oxipng.spec SRPM URL: https://music.fedorapeople.org/rust-oxipng-9.0.0-1.fc39.src.rpm Description: A lossless PNG compression optimizer. Fedora Account System Username: music PR to be merged after unretirement: https://src.fedoraproject.org/rpms/rust-oxipng/pull-request/1 Knowing this is sometimes a problem, I will check the changelog of the unretired package and make sure it is not broken. COPR build (with fedora-review enabled): https://copr.fedorainfracloud.org/coprs/music/oxipng/build/6942075/
Copr build: https://copr.fedorainfracloud.org/coprs/build/6942084 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259760-rust-oxipng/fedora-rawhide-x86_64/06942084-rust-oxipng/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Note that the package includes a few files that should not be installed into the rust-oxipng-devel package: - /scripts/ - /Dockerfile - /index.html In particular, the files in the "scripts" folder cause the package to have a generated dependency on /usr/bin/bash. Please exclude these two files and the "scripts" folder in some way from the -devel package. Option 1: Patching Cargo.toml to update the "exclude" list, or Option 2: Using the %exclude directive in the %files list. If you go with Option 1, that patch might be acceptable by upstream too. They already exclude benchmark and test sources, so they probably don't want to ship other development-only files either.
Thank you for the review! Regarding the extra files, I will go with Option 1 and offer the patch upstream.
https://pagure.io/releng/issue/11960
https://github.com/shssoichiro/oxipng/pull/591
FEDORA-2024-c959cf9e20 (rust-oxipng-9.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c959cf9e20
FEDORA-2024-c959cf9e20 (rust-oxipng-9.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-29e349ef66 (rust-oxipng-9.0.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-29e349ef66
FEDORA-2024-29e349ef66 (rust-oxipng-9.0.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7fbc47eb79 (rust-oxipng-9.0.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7fbc47eb79
FEDORA-2024-28c5dc0c42 (rust-oxipng-9.0.0-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-28c5dc0c42
FEDORA-2024-7fbc47eb79 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7fbc47eb79 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7fbc47eb79 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-28c5dc0c42 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-28c5dc0c42 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-28c5dc0c42 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-28c5dc0c42 (rust-oxipng-9.0.0-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7fbc47eb79 (rust-oxipng-9.0.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.