Red Hat Bugzilla – Bug 226032
Merge Review: libjpeg
Last modified: 2012-06-15 12:26:56 EDT
Fedora Merge Review: libjpeg
Initial Owner: email@example.com
Please find an updated spec file and a patch to the current spec file containing
some suggested changes and fixes :
- Use original IJG source URL and switch to official gz (no bz2 in sight...).
- Move "make test" to %%check section.
- Include install patch to support DESTDIR and fix man pages location.
It could also make sense to split off the binaries and their man pages into a
"tools" sub-package, or maybe "-n jpeg-tools" to not contain "lib" in the name.
Possibly another detail : Does linking statically also require the headers?
Probably, and in which case, we need to either :
- Have the static sub-package require the devel sub-package
- Also include the headers in the static sub-package
Ping? It would be nice to get this package cleaned up for Fedora 8.
Too late for Fedora 8... ping again?
I've updated the modified spec file and patch against the latest libjpeg from CVS, still found here :
Tom, can you please show up at this bug report?
I haven't been too excited about this because hacking on those 1998-vintage makefiles is just putting lipstick on a pig :-(. I am hopeful that the sourceforge project will produce an update sometime soon and then we'll have an upstream that is worth cleaning up.
BTW, the ftp.uu.net address *is* the original, well-published, and still functional URL. Let's not have any historical revisionism in the specfile.
(In reply to comment #7)
> BTW, the ftp.uu.net address *is* the original, well-published, and still
> functional URL. Let's not have any historical revisionism in the specfile.
My bad, I had to hunt down a working URL when I saw that there was no .tar.bz2 there, but that has been resolved since.
As for the makefile change, the one I suggest is trivial and (IMHO) clean. It just sets the paths to the usual Fedora values and adds a $(DESTDIR).
I've just has a look at the sf.net project, and the latest files in CVS don't look much different, so it seems like you have high hopes... I'd suggest cleaning up the package as much as possible now, and if things ever get better later, then great, but if they don't, we'll at least have the package in a somewhat cleaner state.
I still vote for the porcine beautifying :-)
Only a handful of changes in the last 3 years, and none that look anything like cleanups or refactoring, the vintage makefiles seem here to stay.
Time to close this ticket since libjpeg was retired (in the favour of libjpeg-turbo).
This bug just popped out when I searched for packages under review but looks like this package was retired already.
Dropping the flag fedora-review?