Bug 226034 - (libmusicbrainz) Merge Review: libmusicbrainz
Merge Review: libmusicbrainz
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Orcan Ogetbil
Fedora Package Reviews List
: Reopened
Depends On:
Blocks: 486523
  Show dependency treegraph
 
Reported: 2007-01-31 14:25 EST by Nobody's working on this, feel free to take it
Modified: 2009-06-10 13:34 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-06-10 13:34:00 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
oget.fedora: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:25:52 EST
Fedora Merge Review: libmusicbrainz

http://cvs.fedora.redhat.com/viewcvs/devel/libmusicbrainz/
Initial Owner: alexl@redhat.com
Comment 1 Alexander Larsson 2007-02-08 06:11:54 EST
New Initial Owner: bnocera@redhat.com
Comment 2 Rex Dieter 2007-09-13 10:18:13 EDT
I'm maintaining libtunepimp, would you like to comaintain these together?

(If so, I can help review this)
Comment 3 Bastien Nocera 2007-09-13 11:19:52 EDT
libtunepimp is deprecated, isn't it?
I'd be more than happy to have a libmusicbrainz co-maintainer, but I'm not
really interested in maintaining a deprecated library :)
Comment 4 Rex Dieter 2007-09-13 11:48:41 EDT
> libtunepimp is deprecated, isn't it?

news to me, amarok uses it (afaik, amarok2 will too).
Comment 5 Bastien Nocera 2007-09-13 12:21:40 EDT
http://musicbrainz.org/doc/libtunepimpDownload says:

"<!> libtunepimp uses the old RDF WebService and should not be used in new
development. See WebService for more details."
Comment 6 Rex Dieter 2007-09-13 13:32:19 EDT
doh, thanks.
Comment 7 Orcan Ogetbil 2008-10-29 00:19:19 EDT
I did a full review on this package. Everything seems fine except

* docs/mb_howto.txt should be included among %doc, or maybe in devel's %doc
* the examples directory should be included in devel's %doc

Other than these two things the package yields Fedora Guidelines.

A question: Isn't it time to rename this package as libmusicbrainz2 and call libmusicbrainz3 as libmusicbrainz? Is there a particular reason why this is not done yet?
Comment 8 Orcan Ogetbil 2008-12-10 14:05:03 EST
ping?
Comment 9 Rex Dieter 2008-12-10 14:18:55 EST
wrt renaming?

I guess it could be considered (for F-11), Bastien what do you think?

(I'll take care of the other items from comment #7)
Comment 10 Rex Dieter 2008-12-10 14:25:14 EST
Or maybe we can just libmusicbrainz3 -> libmusicbrainz (and EOL existing libmusicbrainz/libtunepimp).
Comment 11 Rex Dieter 2008-12-10 14:28:22 EST
Spoke too soon perhaps, seems there's quite a bit of stuff still depending on libmusicbrainz(2):
libtunepimp(1)
sound-juicer
k3b(1)
gstreamer-plugins-bad
kdemultimedia(1)
rhythmbox(2)

(1) I do these, and it wouldn't break my heart if libmusicbrainz support went away.

(2) Wierd, rhythmbox seems to link to *both* libmusicbrainz/libmusicbrainz3.
Comment 12 Bastien Nocera 2008-12-10 17:24:13 EST
I don't see the point of renaming the library:
- it's not user-facing
- libmusicbrainz (2.x) will soon be useless when MB turn off their old servers
- libmusicbrainz3 is what it's called upstream

Sound-juicer and rhythmbox are already ported to libmusicbrainz3 and use both.
Comment 13 Orcan Ogetbil 2008-12-10 21:23:22 EST
(In reply to comment #12)
> - libmusicbrainz3 is what it's called upstream

I don't think that is the case anymore:
http://musicbrainz.org/doc/libmusicbrainzDownload

But if it is going to cause lots of trouble we can leave things as are.
Comment 14 Rex Dieter 2008-12-12 12:27:19 EST
OK, new proposal:   EOL libmusicbrainz (libtunepimp)
Comment 15 Rex Dieter 2009-01-23 08:32:02 EST
I see no objections, I'll move forward on EOL'ing these asap.

A libmusicbrainz3 pkg rename can be reconsidered at a later date.
Comment 16 Rex Dieter 2009-01-23 08:52:21 EST
Damn, looks like the new kscd in kdemultimedia-4.2.x has a hard-dep on libmusicbrainz... the best laid plans go awry.
Comment 17 Alex Lancaster 2009-02-20 00:34:19 EST
listen also still requires the old libmusicbrainz: bug #486523 please restore.
Comment 18 Orcan Ogetbil 2009-02-20 00:46:42 EST
I don't think it is removed. Please see:

https://www.redhat.com/archives/fedora-devel-list/2009-February/msg01486.html
Comment 19 Alex Lancaster 2009-02-20 01:08:14 EST
It was removed from last night's rawhide, at least temporarily:

http://koji.fedoraproject.org/mash/rawhide-20090219/logs/repodiff

Removed package libmusicbrainz
Removed package libtunepimp
Comment 20 Alex Lancaster 2009-02-20 01:18:29 EST
OK, looks like they were restored in CVS.  I'm going to rebuild them for rawhide now, since it seems that Jesse unblocked them from rawhide.  Hopefully they'll make it into tomorrow's rawhide.
Comment 21 Alex Lancaster 2009-02-20 01:21:52 EST
I guess if they are unblocked, it'll revert to the F-10 version of libmusicbrainz and libtunepimp, so it should at least fix the broken deps.  

Look like libtunepimp doesn't rebuild from source in any case:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1141627
Comment 22 Orcan Ogetbil 2009-04-04 01:47:48 EDT
Could you folks update the package according to comment #7 so we can close the merge review?

I also noticed that there is one occurrence of rm that should be converted to %{__rm} for macro consistency.
Comment 23 Orcan Ogetbil 2009-06-09 15:06:21 EDT
ping? no one wants to fix the trivial things I pointed in comments #7 and #22 ?
Comment 24 Bastien Nocera 2009-06-10 10:54:46 EDT
(In reply to comment #22)
> I also noticed that there is one occurrence of rm that should be converted to
> %{__rm} for macro consistency.  

Done

(In reply to comment #7)
> I did a full review on this package. Everything seems fine except
> 
> * docs/mb_howto.txt should be included among %doc, or maybe in devel's %doc

Done

> * the examples directory should be included in devel's %doc

Done

> Other than these two things the package yields Fedora Guidelines.
> 
> A question: Isn't it time to rename this package as libmusicbrainz2 and call
> libmusicbrainz3 as libmusicbrainz? Is there a particular reason why this is not
> done yet?  

This would be a pretty pointless shuffling of package names.
Comment 25 Orcan Ogetbil 2009-06-10 13:16:39 EDT
Thanks!

The 
   %doc docs/mb_howto.txt examples/README.examples examples/*.c examples/*.cpp
line must come after
   %defattr(-,root,root,-)

Afaict this is the only outstanding issue left.
Comment 26 Bastien Nocera 2009-06-10 13:21:56 EDT
Done in -10
Comment 27 Orcan Ogetbil 2009-06-10 13:34:00 EDT
Yay! All good.

------------------------------------------------------
This merge review (libmusicbrainz) is APPROVED by oget
------------------------------------------------------

Closing.

Note You need to log in before you can comment on or make changes to this bug.