Red Hat Bugzilla – Bug 226048
Merge Review: libtheora
Last modified: 2015-07-15 11:25:15 EDT
Fedora Merge Review: libtheora
Initial Owner: firstname.lastname@example.org
Almost ready for approval (see Maybe and Bad section)
- Package name matches upstream
- Spec file name matches base package name
- License matches actual license, included in %doc, is FLOSS
- Spec written in American English, is legible
- Source matches upstream
- Package builds fine on all supported architectures
- Build requirements complete
- ldconfig called properly
- directory ownerships OK
- files listing: no duplicates
- file permissions OK
- Inter-dependencies OK
- Why --enable-static=yes ?
E: libtheora invalid-version 1.0alpha7
according to the Naming Guidelines, the 'alpha' part should be
part of the release tag
W: libtheora-devel summary-ended-with-dot
E: theora-tools binary-or-shlib-defines-rpath
No documentation for libtheora-devel and theora-tools, but that's fine
- Source URL not provided. Also, use .tar.bz2 instead of .tar.gz?
All the Bads and Maybes seem to be fixed in the current rawhide package, except
for the version. The only way to fix it that I can see would be to add an epoch,
since rpm considers 1.0alpha > 1.0. Is this worth an epoch ?
Introducing an Epoch should be delayed as long as it makes sense. The next
upstream version might for example be "1.1" instead of "1.0" which would mean an
Epoch introduced today would have had only negative effects.
I guess we'll have to wait until a stable version is out (hopefully it won't be
Closing this bug, since in this case it's a review of an existing package and
there's no owner set
I would like to request early branching for F-10 of libtheora
Package Change Request
Package Name: libtheora
New Branches: F-9
(In reply to comment #3)
Re-opening the review.
> Introducing an Epoch should be delayed as long as it makes sense.
We do need to fix this now. See: https://bugzilla.redhat.com/478651
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket:
If you don't know what merge reviews are about, please see:
How to handle this bug is left to the discretion of the package maintainer.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.
(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)
More information and reason for this action is here: