Bug 226068 - Merge Review: libXdmcp
Merge Review: libXdmcp
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 14:30 EST by Nobody's working on this, feel free to take it
Modified: 2009-10-26 12:13 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-10-26 12:13:45 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:30:10 EST
Fedora Merge Review: libXdmcp

http://cvs.fedora.redhat.com/viewcvs/devel/libXdmcp/
Initial Owner: sandmann@redhat.com
Comment 1 Robert Scheck 2009-01-13 17:01:53 EST
libXdmcp.i386: E: zero-length /usr/share/doc/libXdmcp-1.0.2/README
Comment 2 Adam Jackson 2009-02-21 15:59:33 EST
Fixed in 1.0.2-7, along with the other usual suspects.
Comment 3 Parag AN(पराग) 2009-10-08 07:17:46 EDT
Review:

+ koji build =>http://koji.fedoraproject.org/koji/buildinfo?buildID=135669
+ verified upstream source as 
7efd71d29d6cfba797b8791398e4d81ade677d77  libXdmcp-1.0.3.tar.bz2
+ rpmlint is silent.
+ Package libXdmcp-1.0.3-2.fc13.i686 =>
Provides: libXdmcp.so.6
Requires: libXdmcp.so.6 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) rtld(GNU_HASH)
+ Package libXdmcp-devel-1.0.3-2.fc13.i686=>
Provides: pkgconfig(xdmcp) = 1.0.3
Requires: /usr/bin/pkg-config libXdmcp.so.6 pkgconfig(xproto)

APPROVED.
Comment 4 Christoph Wickert 2009-10-12 13:25:05 EDT
- md5sum is d60941d471800f41a3f19b24bea855a7 both for upstream as well as for
the file from lookaside cache
%description should end with a dot.
- make not verbose
- Wraphelp.README.crypto missing from %doc
- README should be in %doc of devel package
Comment 5 Parag AN(पराग) 2009-10-12 23:21:11 EDT
(In reply to comment #4)
> - md5sum is d60941d471800f41a3f19b24bea855a7 both for upstream as well as for
> the file from lookaside cache
 Thought we should start using sha1sum now.

> %description should end with a dot.
 Hmm no guidelines for this.

> - make not verbose
  will take care.

> - Wraphelp.README.crypto missing from %doc
   cool. I missed this.

> - README should be in %doc of devel package  
   ok will also include this.
Comment 6 Christoph Wickert 2009-10-13 04:43:49 EDT
(In reply to comment #5)
>  Thought we should start using sha1sum now.

At least not according to the review guidelines.

> > %description should end with a dot.
>  Hmm no guidelines for this.

rpmlint used to warn about this. Summary should not end with a dot, description should.
Comment 7 Parag AN(पराग) 2009-10-21 05:13:06 EDT
updated package in F-13

Note You need to log in before you can comment on or make changes to this bug.