Red Hat Bugzilla – Bug 226068
Merge Review: libXdmcp
Last modified: 2009-10-26 12:13:45 EDT
Fedora Merge Review: libXdmcp http://cvs.fedora.redhat.com/viewcvs/devel/libXdmcp/ Initial Owner: sandmann@redhat.com
libXdmcp.i386: E: zero-length /usr/share/doc/libXdmcp-1.0.2/README
Fixed in 1.0.2-7, along with the other usual suspects.
Review: + koji build =>http://koji.fedoraproject.org/koji/buildinfo?buildID=135669 + verified upstream source as 7efd71d29d6cfba797b8791398e4d81ade677d77 libXdmcp-1.0.3.tar.bz2 + rpmlint is silent. + Package libXdmcp-1.0.3-2.fc13.i686 => Provides: libXdmcp.so.6 Requires: libXdmcp.so.6 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) rtld(GNU_HASH) + Package libXdmcp-devel-1.0.3-2.fc13.i686=> Provides: pkgconfig(xdmcp) = 1.0.3 Requires: /usr/bin/pkg-config libXdmcp.so.6 pkgconfig(xproto) APPROVED.
- md5sum is d60941d471800f41a3f19b24bea855a7 both for upstream as well as for the file from lookaside cache %description should end with a dot. - make not verbose - Wraphelp.README.crypto missing from %doc - README should be in %doc of devel package
(In reply to comment #4) > - md5sum is d60941d471800f41a3f19b24bea855a7 both for upstream as well as for > the file from lookaside cache Thought we should start using sha1sum now. > %description should end with a dot. Hmm no guidelines for this. > - make not verbose will take care. > - Wraphelp.README.crypto missing from %doc cool. I missed this. > - README should be in %doc of devel package ok will also include this.
(In reply to comment #5) > Thought we should start using sha1sum now. At least not according to the review guidelines. > > %description should end with a dot. > Hmm no guidelines for this. rpmlint used to warn about this. Summary should not end with a dot, description should.
updated package in F-13