Fedora Merge Review: libxklavier http://cvs.fedora.redhat.com/viewcvs/devel/libxklavier/ Initial Owner: rstrode
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1497503 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 37c6e9fb8b436d6a646a6eea09cf196baad28756 libxklavier-4.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + libxklavier.pc file present. + -devel subpackage present. + no .la files. + no translations are available + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libxklavier-4.0-3.fc12.i686=> Provides: libxklavier.so.15 Requires: libX11.so.6 libXi.so.6 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libglib-2.0.so.0 libgobject-2.0.so.0 libxkbfile.so.1 libxklavier.so.15 libxml2.so.2 rtld(GNU_HASH) + Package libxklavier-devel-4.0-3.fc12.i686 => Provides: pkgconfig(libxklavier) = 4.0 Requires: /usr/bin/pkg-config libxklavier.so.15 pkgconfig(libxml-2.0) + Not a GUI application Should: 1) follow http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps
I also don't get why we need Requires: libxml2-devel for -devel subpackage?
It used to be necessary because the .pc file has a Requires: libxml-2.0 Nowadays, pkg-config autodeps should take care of it, so it can go.
There are no blockers for this review. APPROVED