Bug 2263972 - Cockpit storage: incorrectly displays the "Type" of an EFI system partition it previously created as "vfat filesystem"
Summary: Cockpit storage: incorrectly displays the "Type" of an EFI system partition i...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cockpit
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Marius Vollmer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: AnacondaWebUITracker
TreeView+ depends on / blocked
 
Reported: 2024-02-13 02:40 UTC by Adam Williamson
Modified: 2024-03-01 01:39 UTC (History)
5 users (show)

Fixed In Version: cockpit-311-1.fc39 cockpit-311-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-16 01:41:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot of the issue (affected partition is vda1) (437.48 KB, image/png)
2024-02-13 02:41 UTC, Adam Williamson
no flags Details

Description Adam Williamson 2024-02-13 02:40:27 UTC
While fiddling around with the Cockpit storage interface, I noticed it was showing an EFI system partition it had itself previously created as "vfat filesystem".

The partition is, at this time, not a part of any identifiable OS install (because I've been screwing around with the partitioning tool a lot without actually completing an install). But it is still identifiable as an EFI system partition because these have a unique partition type. `fdisk` correctly shows its type as "EFI System".

Comment 1 Adam Williamson 2024-02-13 02:41:42 UTC
Created attachment 2016556 [details]
screenshot of the issue (affected partition is vda1)

Comment 2 Marius Vollmer 2024-02-13 09:05:41 UTC
"Technically", Cockpit is not wrong: the EFI system partition indeed has a vfat filesystem on it, and the thing that makes it EFI is its partition type. But I agree that this is not helpful and Cockpit should list the EFI system partition as "EFI System partition". Cockpit might even start complaining if you a partition has the EFI type but not a vfat filesystem, or a different mount point than /boot/efi.

This is even worse for bios boot partitions: they don't even have a filesystem on them and are listed as "Unformatted data".

Thanks for pointing this out! I have bumped the priority for fixing this.

Comment 3 Marius Vollmer 2024-02-13 10:54:09 UTC
https://github.com/cockpit-project/cockpit/pull/20010

Comment 4 Fedora Update System 2024-02-14 20:31:36 UTC
FEDORA-2024-7b0bc52005 (cockpit-311-1.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7b0bc52005

Comment 5 Fedora Update System 2024-02-14 20:31:58 UTC
FEDORA-2024-be44af3059 (cockpit-311-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-be44af3059

Comment 6 Fedora Update System 2024-02-15 01:37:30 UTC
FEDORA-2024-be44af3059 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-be44af3059`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-be44af3059

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-02-15 01:53:11 UTC
FEDORA-2024-7b0bc52005 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7b0bc52005`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7b0bc52005

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-02-16 01:41:14 UTC
FEDORA-2024-be44af3059 (cockpit-311-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-03-01 01:39:55 UTC
FEDORA-2024-7b0bc52005 (cockpit-311-1.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.