Bug 2264523 - Confusion about "Name" of partition
Summary: Confusion about "Name" of partition
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: cockpit
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Marius Vollmer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: AnacondaWebUITracker
TreeView+ depends on / blocked
 
Reported: 2024-02-16 10:07 UTC by Jan Stodola
Modified: 2025-02-26 12:58 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
screenshot (91.29 KB, image/png)
2024-02-16 10:08 UTC, Jan Stodola
no flags Details

Description Jan Stodola 2024-02-16 10:07:14 UTC
When creating a new partition in cockpit storage in the installer, there is a field called "Name" as the first one.
My initial thought was to enter the mount point ("/"), but since there is another field called "Mount point", I got really confused what is the purpose of the "Name" field.

Some possibilities in my mind are:
1. I can write the name of the new block device: "/dev/vda1"
2. I can use it to set the file system label: "rootfs"
3. It is used as some kind of user-friendly identifier for the next steps of the installer: "My root file system"

Also, it's not clear to me if the "Name" field is optional or mandatory.

Can you please clarify the purpose of the "Name" field?

Reproducible: Always

Comment 1 Jan Stodola 2024-02-16 10:08:50 UTC
Created attachment 2017172 [details]
screenshot

Comment 2 Jelle van der Waa 2024-02-19 08:25:30 UTC
Thanks for the issue, the Name in the "Create Partition" dialog is the filesystem label which afterwards can be changed. The dialog might be confusing as you are doing two steps at once, creating a partition and creating a filesystem usually if you do this by hand it's two separate steps either cfdisk /dev/sda, do your partitioning and then mkfs.xfs /dev/sda2. So maybe that should be more clear?

Comment 3 Marius Vollmer 2024-02-19 09:25:56 UTC
Maybe we should just remove the "Name" field from the dialog? People can always set it later, and its present in the dialog seems to be more confusing than useful.

Comment 4 Marius Vollmer 2024-02-19 09:27:36 UTC
Maybe we should just remove the "Name" field from the dialog? People can always set it later, and its presence in the dialog seems to be more confusing than useful.

Comment 5 Jan Stodola 2024-02-19 10:15:02 UTC
I think the field would be perfectly fine if it was called for example "File System Label" and was not on top of the dialog window.

Removing the field is also fine from my point of view if it can be returned in case the users request it. Based on our survey from 2022, about 6.5% of people change a device label during the installation.

Comment 6 Vojtech Trefny 2024-02-19 13:49:56 UTC
(In reply to Jelle van der Waa from comment #2)
> the Name in the "Create Partition" dialog is the filesystem label

In that case, I think it would be worth renaming the field to "filesystem label" -- (GPT) partitions can also have names and when I first saw this, I thought it's partition name and not filesystem label.

Comment 7 Marius Vollmer 2024-02-21 08:59:38 UTC
(In reply to Jan Stodola from comment #5)
> I think the field would be perfectly fine if it was called for example "File
> System Label" and was not on top of the dialog window.

Yes, let's do that.

Comment 8 Marius Vollmer 2024-02-21 09:50:25 UTC
https://github.com/cockpit-project/cockpit/pull/20066

Comment 9 Aoife Moloney 2025-02-26 12:58:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.


Note You need to log in before you can comment on or make changes to this bug.