Bug 2264540 - Fields for entering LUKS passphrase are hidden
Summary: Fields for entering LUKS passphrase are hidden
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: cockpit
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Marius Vollmer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: AnacondaWebUITracker
TreeView+ depends on / blocked
 
Reported: 2024-02-16 12:53 UTC by Jan Stodola
Modified: 2025-02-26 12:58 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
Screencast (317.52 KB, application/octet-stream)
2024-02-16 12:54 UTC, Jan Stodola
no flags Details

Description Jan Stodola 2024-02-16 12:53:49 UTC
I tried to create an encrypted partition in cockpit storage in anaconda WebUI, but my first attempt failed, because the "Create" button did nothing after clicking on it.

My expectation was there would be a popup window asking me for a passphrase.

Only later I noticed I have to scroll the dialog window, where I have to provide the passphrase.

There is a scrollbar on the right side of the dialog window, but it's pretty thin and hides very quickly - making it hard to spot. See the attached screencast.

Reproducible: Always

Comment 1 Jan Stodola 2024-02-16 12:54:35 UTC
Created attachment 2017197 [details]
Screencast

Comment 2 Garrett LeSage 2024-02-19 08:23:50 UTC
@mvollmer: We should probably use element.scrollIntoView() with the (alignToTop boolean set) on the Encryption entry, after a change in the dropdown. This would show that the inside is scrollable as well as show the encryption information when relevant.

See: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView

On larger or screens or changing back to none, the scroll will have no effect, as it's the last part of the modal.

Comment 3 Marius Vollmer 2024-02-19 09:34:19 UTC
(In reply to Garrett LeSage from comment #2)
> @mvollmer: We should probably use element.scrollIntoView() with the
> (alignToTop boolean set) on the Encryption entry, after a change in the
> dropdown. 

Yes, good idea. Also, when people click on Apply and there are validation errors for certain fields, we should scroll those fields into view.

Comment 4 Garrett LeSage 2024-02-19 12:10:47 UTC
> when ... there are validation errors ..., we should scroll those fields into view.

Sure, that would be good as well, but only scroll to the topmost element that contains an error. (It would get unpredictable if there are multiples and you told it to scroll to all.) Then if that is fixed, assuming there are still multiple errors and a small viewport, it'd scroll to the next that wasn't addressed.

Comment 5 Marius Vollmer 2024-02-19 12:26:09 UTC
https://github.com/cockpit-project/cockpit/pull/20060

Comment 6 Aoife Moloney 2025-02-26 12:58:18 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.


Note You need to log in before you can comment on or make changes to this bug.