Fedora Merge Review: tar
Initial Owner: email@example.com
tar-1.16.1.tar.bz2 plus sig is available upstream.
> Prereq: info
> %makeinstall bindir=$RPM_BUILD_ROOT/bin libexecdir=$RPM_BUILD_ROOT/sbin
Standard make install with DESTDIR ought to be preferred, provided
that it works:
make DESTDIR=$RPM_BUILD_ROOT bindir=/bin libexecdir=/sbin install
The %makeinstall macro overrides many Make variables, which can lead
to %buildroot finding its way into built files.
> install -c -m
Wherever files are installed manually, add option "-p" to preserve
time-stamps, so files which haven't changed for a long time are easier
to spot when browsing installed package contents.
> BuildRoot: ...
Doesn't match the Fedora standard
and might be rejected as soon as it might become mandatory.
> tar-1.16.1.tar.bz2 plus sig is available upstream.
I know about it, but there are still problems with tar-1.16.1.(#226917)
The rest is fixed in:
* With the better scriptlet dependencies on /sbin/install-info in
place, "Prereq: info" can be deleted:
$ rpmlint tar-1.15.1-26.src.rpm
W: tar prereq-use info
* Other releases of tar may need "BuildRequires: gettext" for the
message object files. This version doesn't.
* The changes in cvs look fine.
* A side-note about the binary rpm:
$ rpmlint tar-1.15.1-26.i386.rpm
W: tar file-not-utf8 /usr/share/info/tar.info-1.gz
W: tar file-not-utf8 /usr/share/info/tar.info.gz
Indeed, in a single line in both files, Jörg Schilling's name is
encoded in ISO 8859-1. That alone would be easy to fix with "iconv",
and a created patch shows no accidental conversions.
However, there are a few 0x0c carriage-return values in those files
(and also in the texinfo input files), which cause these paragraphs,
where the encoding is wrong, to be hidden when displaying the
documentation with "info". I don't know whether the 0x0c are intentional
or supposed to be 0x0a instead.
If you want to check upgrade candidate too, you can find it at: