Bug 226539 - Merge Review: which
Merge Review: which
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ruben Kerkhof
Fedora Package Reviews List
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:16 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-15 16:16 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-15 16:16:57 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:16:30 EST
Fedora Merge Review: which

http://cvs.fedora.redhat.com/viewcvs/devel/which/
Initial Owner: than@redhat.com
Comment 1 Ruben Kerkhof 2007-02-04 06:53:55 EST
Review for release 8:
* RPM name is OK
* Source which-2.16.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
  COPYING is included in the source, please add it to %doc
* Please change hardcoded paths with macro's
* Preserve timestamps when installing files
* Please consider using {?dist} in the Release Tag (http://fedoraproject.org/wiki/DistTag)

Rpmlint is not silent:

Source RPM:
W: which summary-ended-with-dot Displays where a particular program in your path is located.
W: which strange-permission which-2.sh 0775
W: which redundant-prefix-tag
W: which prereq-use /sbin/install-info
W: which prereq-use dev
Use Requires(post) and Requires(preun). What's the prereq dev for?

rpmlint of which:
W: which summary-ended-with-dot Displays where a particular program in your path is located.
W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh
E: which executable-marked-as-config-file /etc/profile.d/which-2.sh
E: which executable-sourced-script /etc/profile.d/which-2.sh 0755
Comment 2 Robert Scheck 2007-02-18 17:43:01 EST
Isn't a which-2.csh script missing?
Comment 3 Ruben Kerkhof 2007-04-20 18:36:55 EDT
Ping?
Comment 4 Ngo Than 2007-04-23 09:04:46 EDT
all above bugs are fixed in rawhide. thanks
Comment 5 Ruben Kerkhof 2007-07-05 14:02:38 EDT
Review for release 9:
* RPM name is OK
* Source which-2.16.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Rpmlint is not clean.

Source RPM:
W: which strange-permission which-2.csh 0775
W: which strange-permission which-2.sh 0775

0644 will do just fine, the files are sourced.

rpmlint of which:
E: which executable-marked-as-config-file /etc/profile.d/which-2.csh
E: which executable-sourced-script /etc/profile.d/which-2.csh 0755
E: which executable-marked-as-config-file /etc/profile.d/which-2.sh
E: which executable-sourced-script /etc/profile.d/which-2.sh 0755

Solved quite easy by setting permissions to 0644

W: which incoherent-version-in-changelog 2.16-9.fc7 2.16-9.fc8

Don't use the disttag in the changelog

W: which conffile-without-noreplace-flag /etc/profile.d/which-2.csh
W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh

Use %config(noreplace) in your file section
Comment 6 Lubomir Kundrak 2007-11-13 07:13:56 EST
Than: What prevents you from finishing the review? May I help you somehow? I
assume you plan to build the new package once the review is finished. I'm
interested in getting the package without the (bug #99275) dev dependency, as it
unnecessarily pulls udev and doesn't serve its purpose any longer. Or will you
be angry at me if I initiated the build?
Comment 7 Lubomir Kundrak 2007-11-13 07:14:58 EST
(In reply to comment #5)
/profile.d/which-2.csh
> W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh
> 
> Use %config(noreplace) in your file section

Ruben: I think these are not configuration files and are meant to be replaced
with updates. It is just safe to ignore the rpmlint warning.
Comment 8 Ngo Than 2007-11-13 08:18:51 EST
>Source RPM:
>W: which strange-permission which-2.csh 0775
>W: which strange-permission which-2.sh 0775

fixed in which-2_16-10

>rpmlint of which:
>E: which executable-marked-as-config-file /etc/profile.d/which-2.csh
>E: which executable-sourced-script /etc/profile.d/which-2.csh 0755
>E: which executable-marked-as-config-file /etc/profile.d/which-2.sh
>E: which executable-sourced-script /etc/profile.d/which-2.sh 0755

fixed in which-2_16-10

>W: which incoherent-version-in-changelog 2.16-9.fc7 2.16-9.fc8
>
>Don't use the disttag in the changelog
fixed in which-2_16-10

>W: which conffile-without-noreplace-flag /etc/profile.d/which-2.csh
>W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh
it's not config files, i removed the config macros

it's build in rawhide. Thanks for your review
Comment 9 Lubomir Kundrak 2007-11-13 09:11:56 EST
Than: You should not close bugs that are not assigned to you. This time it's
Ruben's duty to close bug once he verifies that the package is really fixed.
Comment 10 Ruben Kerkhof 2007-11-19 18:26:55 EST
Hi Than,

Still rpmlint errors:

[ruben@odin devel]$ rpmlint which-2.18-1.fc9.src.rpm 
which.src: W: invalid-license GPL
which.src: W: strange-permission which-2.csh 0775
which.src: W: strange-permission which-2.sh 0775

Can you replace /etc with %{sysconfdir} in the spec?


Comment 11 Ngo Than 2007-11-20 08:31:39 EST
>which.src: W: strange-permission which-2.csh 0775
>which.src: W: strange-permission which-2.sh 0775
strange, it's already fixed in this version. I didn't see this Warning here! 
could you please check again? Thanks

>Can you replace /etc with %{sysconfdir} in the spec?
it's fixed in which-2.18-2.fc9.

>which.src: W: invalid-license GPL
I have taken a look at COPYING here. It's GPL! What is wrong here? 


Comment 12 Ngo Than 2007-11-20 08:46:19 EST
it's fixed in which-2.18-2.fc9. could you please review it again. Thanks
Comment 13 Lubomir Kundrak 2007-11-20 08:49:06 EST
> >which.src: W: invalid-license GPL
> I have taken a look at COPYING here. It's GPL! What is wrong here? 

It has to be GPL, GPL+, GPLv2, GPLv2+, GPLv3 or GPLv3+
http://fedoraproject.org/wiki/Licensing
Comment 14 Ruben Kerkhof 2007-11-26 10:27:05 EST
The list of licenses rpmlint checks for can be found in /usr/share/rpmlint/config.

I think GPLv2+ is the one you need (based on the text in which.c)
Comment 15 Ngo Than 2007-11-26 10:37:35 EST
it's now fixed in which-2.18-2.fc9. could you please verify again? Thanks
Comment 16 Ruben Kerkhof 2007-11-26 15:25:25 EST
Ok, that looks good, thanks.

Now those warnings returned:
>which.src: W: strange-permission which-2.csh 0775
>which.src: W: strange-permission which-2.sh 0775

I'm not sure, but maybe a CVS admin has to set the permissions in the repository.


Comment 17 Ngo Than 2007-11-27 09:06:26 EST
i now have added explicit correct %attr for those files. It should be fine now 
in which-2_18-4_fc9. Could you please check again. Thanks
Comment 18 Ruben Kerkhof 2007-11-27 13:45:36 EST
The warning is not about the permissions on the files after they are installed, it's about how they are 
stored in the srpm:

[ruben@odin devel]$ rpmlint -i which-2.18-4.fc9.src.rpm 
which.src: W: strange-permission which-2.csh 0775
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.

which.src: W: strange-permission which-2.sh 0775
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.

ruben@odin devel]$ ls -l which-2.*sh
-rwxrwxr-x 1 ruben ruben 162 2007-04-23 15:04 which-2.csh
-rwxrwxr-x 1 ruben ruben 170 2004-09-09 16:18 which-2.sh
Comment 19 Ngo Than 2007-11-27 17:56:13 EST
ok, i have renamed which-2.*sh to which2.*sh with the correct permission. It's 
fixed in which-2_18-5_fc9
Comment 20 Lubomir Kundrak 2007-12-18 15:00:15 EST
Ruben: Is the package fine now?
Comment 21 Ruben Kerkhof 2007-12-18 17:57:57 EST
Thanks, approved

Note You need to log in before you can comment on or make changes to this bug.