Bug 226562 - Merge Review: xkeyboard-config
Merge Review: xkeyboard-config
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
http://freedesktop.org/wiki/Software/...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:20 EST by Nobody's working on this, feel free to take it
Modified: 2010-07-23 04:36 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-19 20:58:36 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
xkeyboard-config-spec-cleanup.patch (1.66 KB, patch)
2010-07-19 12:31 EDT, Parag AN(पराग)
no flags Details | Diff
spec patch to get rid of awk 'Patch' file extraction madness (357 bytes, patch)
2010-07-19 12:48 EDT, Michael Schwendt
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:20:03 EST
Fedora Merge Review: xkeyboard-config

http://cvs.fedora.redhat.com/viewcvs/devel/xkeyboard-config/
Initial Owner: krh@redhat.com
Comment 1 Marcin Garski 2007-04-21 09:02:00 EDT
It would be good to add URL:
http://freedesktop.org/wiki/Software_2fXKeyboardConfig and update to 0.9 (bug
237369).

Of course this is not a review :) Just my comment.
Comment 2 Marcin Garski 2007-06-22 06:07:36 EDT
New URL: http://freedesktop.org/wiki/Software/XKeyboardConfig

BTW. Any progress here?
Comment 3 Parag AN(पराग) 2010-07-19 12:00:05 EDT
1)rpmlint reported
xkeyboard-config.src:45: E: use-of-RPM_SOURCE_DIR
===>you use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
a directory for building, use $RPM_BUILD_ROOT instead.

xkeyboard-config.src: W: patch-not-applied Patch2: 0001-Add-Euro-and-New-Shekel-sign-to-israeli-layout.patch
xkeyboard-config.src: W: patch-not-applied Patch3: 0001-symbols-de-remove-BKSP-from-neo-layout.patch
xkeyboard-config.src: W: patch-not-applied Patch4: 0001-Remove-duplicate-BKSL-key-mappings-from-hin-wx-layou.patch
==>here patch is applied in different way, so ignore this
xkeyboard-config.noarch: W: no-documentation


2)timestamps should be preserved.Use INSTALL="install -p" when installing to preserve timestamps.

3)Should use https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

4) I will suggest this pacakge to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install
Comment 4 Parag AN(पराग) 2010-07-19 12:31:09 EDT
Created attachment 432942 [details]
xkeyboard-config-spec-cleanup.patch

I am not sure how to fix rpmlint error message for %{_sourcedir} as this is needed for patches.
Comment 5 Michael Schwendt 2010-07-19 12:48:18 EDT
Created attachment 432948 [details]
spec patch to get rid of awk 'Patch' file extraction madness
Comment 6 Peter Hutterer 2010-07-19 20:58:36 EDT
(In reply to comment #4)
> Created an attachment (id=432942) [details]
> xkeyboard-config-spec-cleanup.patch
> 
> I am not sure how to fix rpmlint error message for %{_sourcedir} as this is
> needed for patches.    

committed, thanks.

(In reply to comment #5)
> Created an attachment (id=432948) [details]
> spec patch to get rid of awk 'Patch' file extraction madness    

call me lazy, but I prefer it that way. saves me from updating two parts of the spec file for patches.
Comment 7 Michael Schwendt 2010-07-21 02:55:36 EDT
Sure, ... I also see the value in the awk command, if to be used with many more than three patch files and no conditionally applied ones. Still, when explicitly using the %{PATCHn} macros, rpmlint and Fedora pkg cvs Makefile at least __could__ try to get the warning about unapplied patches right.
Comment 8 Parag AN(पराग) 2010-07-23 04:36:16 EDT
Marking it as Reviewed. Leaving the applying patch issue to its package maintainer.

APPROVED.

Note You need to log in before you can comment on or make changes to this bug.