Fedora Merge Review: xkeyboard-config http://cvs.fedora.redhat.com/viewcvs/devel/xkeyboard-config/ Initial Owner: krh
It would be good to add URL: http://freedesktop.org/wiki/Software_2fXKeyboardConfig and update to 0.9 (bug 237369). Of course this is not a review :) Just my comment.
New URL: http://freedesktop.org/wiki/Software/XKeyboardConfig BTW. Any progress here?
1)rpmlint reported xkeyboard-config.src:45: E: use-of-RPM_SOURCE_DIR ===>you use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead. xkeyboard-config.src: W: patch-not-applied Patch2: 0001-Add-Euro-and-New-Shekel-sign-to-israeli-layout.patch xkeyboard-config.src: W: patch-not-applied Patch3: 0001-symbols-de-remove-BKSP-from-neo-layout.patch xkeyboard-config.src: W: patch-not-applied Patch4: 0001-Remove-duplicate-BKSL-key-mappings-from-hin-wx-layou.patch ==>here patch is applied in different way, so ignore this xkeyboard-config.noarch: W: no-documentation 2)timestamps should be preserved.Use INSTALL="install -p" when installing to preserve timestamps. 3)Should use https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make 4) I will suggest this pacakge to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install
Created attachment 432942 [details] xkeyboard-config-spec-cleanup.patch I am not sure how to fix rpmlint error message for %{_sourcedir} as this is needed for patches.
Created attachment 432948 [details] spec patch to get rid of awk 'Patch' file extraction madness
(In reply to comment #4) > Created an attachment (id=432942) [details] > xkeyboard-config-spec-cleanup.patch > > I am not sure how to fix rpmlint error message for %{_sourcedir} as this is > needed for patches. committed, thanks. (In reply to comment #5) > Created an attachment (id=432948) [details] > spec patch to get rid of awk 'Patch' file extraction madness call me lazy, but I prefer it that way. saves me from updating two parts of the spec file for patches.
Sure, ... I also see the value in the awk command, if to be used with many more than three patch files and no conditionally applied ones. Still, when explicitly using the %{PATCHn} macros, rpmlint and Fedora pkg cvs Makefile at least __could__ try to get the warning about unapplied patches right.
Marking it as Reviewed. Leaving the applying patch issue to its package maintainer. APPROVED.