Bug 226612 - Merge Review: xorg-x11-drv-nv
Merge Review: xorg-x11-drv-nv
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 16:28 EST by Nobody's working on this, feel free to take it
Modified: 2009-02-21 18:15 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-02-21 18:15:25 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:28:10 EST
Fedora Merge Review: xorg-x11-drv-nv

Initial Owner: ajackson@redhat.com
Comment 1 Jason Tibbitts 2007-06-22 01:11:29 EDT
Abbreviated mass review of xorg-x11-drv-* packages.

Unfortunately there's no info in the spec about where the nouveau driver is
hosted, so I can't grab the commit to do a comparison.  Could you add just a
line indicating how to do a pull?

rpmlint says:
W: xorg-x11-drv-nv mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 3)
which is fine.

The only other issue I have is that neither of the make calls has
%{?_smp_mflags}.  Is there some issue that makes parallel builds not useful?
Comment 2 Adam Jackson 2009-02-21 17:07:16 EST
Fixed smp_mflags in 2.1.12-9.  nouveau is a separate package now, so I think this is done.
Comment 3 Jason Tibbitts 2009-02-21 18:15:25 EST
Indeed, this is fine; the nouveau driver is split out and the other bits are cleaned up.  Thanks.

I would urge some additional documentation of the patches since this package is starting to accumulate quite a few of them that don't seem to be going upstream.  I see there there's some reasonable info in the changelog, but it would be good to have consistent links to Red Hat bugzilla or the upstream bug tracker.

APPROVED and closed.

Note You need to log in before you can comment on or make changes to this bug.