Bug 226892 - Review Request: kpowersave - kde power control applet
Review Request: kpowersave - kde power control applet
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Aurelien Bompard
Fedora Package Reviews List
Depends On: 226891
  Show dependency treegraph
Reported: 2007-02-01 16:31 EST by Dennis Gilmore
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-02-04 13:36:42 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Dennis Gilmore 2007-02-01 16:31:21 EST
Spec URL: http://www.ausil.us/packages/kpowersave.spec
SRPM URL: http://www.ausil.us/packages/kpowersave-0.7.1-1.src.rpm 
Description: power control applet for kde
Comment 1 Aurelien Bompard 2007-02-02 04:00:03 EST
Needs work:
* Source 0 is not available, please replace it with
* BuildRequires: desktop-file-utils is missing
* Build failed in mock, missing buildrequires: hal-devel (at least). Please test
the build in mock.
Comment 2 Dennis Gilmore 2007-02-02 11:53:53 EST
i grabbed the tarball from the ftp site  but have changed the url.
build in mock 
SRPM: http://www.ausil.us/packages/kpowersave-0.7.1-2.al3.src.rpm
SPEC: http://www.ausil.us/packages/kpowersave.spec
Comment 3 Aurelien Bompard 2007-02-03 05:27:15 EST
Needs work:
* Please remove /usr/lib/libkdeinit_kpowersave.la, it should be useless
/usr/lib/kde3/kpowersave.la is probably needed however, please keep it.
* As kpowersave ships icons in the hicolor directory, it should have "Requires:

Everything else looks OK, good job.
Comment 4 Dennis Gilmore 2007-02-03 17:08:54 EST
libkdeinit .la files are needed and kdelibs requires hicolor-icon-theme  so 
the requires is redundant.
Comment 5 Aurelien Bompard 2007-02-04 04:08:42 EST
Thanks for the clarification.

Review for release 2.fc6:
* RPM name is OK
* Source kpowersave-0.7.1.tar.bz2 is the same as upstream
* This is the latest version
* rpmlint looks OK
* File list looks OK
* Builds fine in mock
* Works fine
(36 automatic checks have been run by fedora-qa)

Comment 6 Dennis Gilmore 2007-02-04 13:36:42 EST
Built in devel and FC-6  thanks for the review.

Note You need to log in before you can comment on or make changes to this bug.