Red Hat Bugzilla – Bug 227067
Review Request: javassist - Java Programming Assistant: bytecode manipulation
Last modified: 2014-12-01 18:13:51 EST
Spec URL: http://people.redhat.com/rafaels/specs/javassist-3.1-1jpp.spec SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/javassist-3.1-1jpp.src.rpm Description: Javassist (Java Programming Assistant) makes Java bytecode manipulation simple. It is a class library for editing bytecodes in Java; it enables Java programs to define a new class at runtime and to modify a class file when the JVM loads it. Unlike other similar bytecode editors, Javassist provides two levels of API: source level and bytecode level. If the users use the source-level API, they can edit a class file without knowledge of the specifications of the Java bytecode. The whole API is designed with only the vocabulary of the Java language. You can even specify inserted bytecode in the form of source text; Javassist compiles it on the fly. On the other hand, the bytecode-level API allows the users to directly edit a class file as other editors. Samples for javassist. Javadoc for javassist. Tutorial for javassist.
Review Comments * incorrect buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * changelog should be in one of these formats: (without epoch) * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> - 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> 0.6-4 - And fix the link syntax. * Fri Jun 23 2006 Jesse Keating <jkeating@redhat.com> - 0.6-4 - And fix the link syntax. * Summary tag should not end in a period * use macros appropriately and consistently - ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
Package won't build, here's first error. [javac] 55. ERROR in /notnfs/klee/RPMBUILDS/BUILD/javassist-3.1/src/main/jav assist/util/HotSwapper.java [javac] (at line 18) [javac] import com.sun.jdi.*; [javac] ^^^^^^^^^^^ [javac] The import com.sun.jdi cannot be resolved
After running rpmlint : W: javassist non-standard-group Development/Libraries/Java E: javassist unknown-key GPG#c431416d
So other than the comments you made, was the rest of the package okay? Please add the other comments in the future (ie. even the ones that aren't problems). Thanks.
After double chekcing, * it should not have Vendor Tag. And rest of them is okay.
Updated spec and SRPM: http://overholt.ca/fedora/javassist.spec http://overholt.ca/fedora/javassist-3.1-1jpp.1.src.rpm Other things fixed: Renamed specfile to javassist.spec Remove %define section devel Added .1%{?dist} It still doesn't build due to the com.sun.jdi dependencies. I don't see this getting fixed until we import Keith's JDWP work. CCing Keith Seitz and Tom Tromey to get their opinion as to whether or not we'll have com.sun.jdi.VirtualMachine any time soon.
Nope, our JDWP implementation does not include com.sun.jdi. In fact, I had never heard of that until just now :)
Keith: have you heard of com.sun.jdi?
Yeah, JDI is yet another of the API layers on top of JVMTI that one can use to do all sorts of things to a VM. JDWP won't help because we don't use that layer. We could, for sure, but just look at how JVMTI mucked with the schedule. More info here: http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdi/index.html
new version requested for review: bug 252099
*** Bug 252099 has been marked as a duplicate of this bug. ***
Resetting assigned status to new because it wasn't really assigned to anyone.
Can we get a package that's somewhat close to the current guidelines? Is anyone associated with this ticket still around to drive it?
Never mind, this must have been reviewed and approved in a different ticket. *** This bug has been marked as a duplicate of bug 475508 ***