Bug 227252 - Review Request: xine-plugin - mozilla plugin using libxine as backend
Review Request: xine-plugin - mozilla plugin using libxine as backend
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Aurelien Bompard
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-02-03 19:45 EST by Martin Sourada
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-15 15:48:18 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
gauret: fedora‑review+
petersen: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Martin Sourada 2007-02-03 19:45:05 EST
Spec URL: http://feannatar.hostuju.cz/fedora/files/FC6/SPECS/xine-plugin.spec
SRPM URL: http://feannatar.hostuju.cz/fedora/files/FC6/SRPMS/xine-plugin-1.0-1.src.rpm
Description: 
This is a very simple netscape/mozilla browser plugin using the xine
engine to display multimedia streams.

Features:

- embedded display on browser window
- streaming playback directly from xine engine
- playback control using keyboard
- relative paths supported
- on screen display of buffering and stream information
- playlists and references support
- loop and repeat mode
- multiple instances within the same page
- javascript support

Note: I am not sponsored.
Comment 1 Aurelien Bompard 2007-03-10 16:29:40 EST
Missing BuildRequires: xorg-x11-proto-devel, libX11-devel
Apart from that, it looks good.
Comment 2 Martin Sourada 2007-03-13 14:56:12 EDT
(In reply to comment #1)
> Missing BuildRequires: xorg-x11-proto-devel, libX11-devel
> Apart from that, it looks good.

Thanks, I missed them. Fixed.

New SPEC: http://feannatar.hostuju.cz/fedora/files/FC6/SPECS/xine-plugin.spec
New SRPM:
http://feannatar.hostuju.cz/fedora/files/FC6/SRPMS/xine-plugin-1.0-2.src.rpm
Comment 3 Aurelien Bompard 2007-03-13 17:56:24 EDT
Review for release 2.fc6:
* RPM name is OK
* Source xine-plugin-1.0.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine

Detail : the two BuildRequires you just added have been lined up with tabs
(lines 14 and 15, see rpmlint). Change them to spaces before or after importing
please.

APPROVED. I'll sponsor you.
Comment 4 Martin Sourada 2007-03-14 11:02:23 EDT
Thanks. I fixed the rpmlint warning and added cvsextras and fedorabugs
membership to my fedora account.
Comment 5 Martin Sourada 2007-03-14 18:53:23 EDT
New Package CVS Request
=======================
Package Name: xine-plugin
Short Description: Simple mozilla browser plugin using xine-lib engine
Owners: martin.sourada@seznam.cz
Branches: FC-6
InitialCC: martin.sourada@seznam.cz
Comment 6 Jens Petersen 2007-03-15 02:16:40 EDT
done  (since you are the owner no need to list yourself under cc too btw)

Note You need to log in before you can comment on or make changes to this bug.