Bug 2279016 - Review Request: rust-freedesktop-desktop-entry - Freedesktop Desktop Entry Specification
Summary: Review Request: rust-freedesktop-desktop-entry - Freedesktop Desktop Entry Sp...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/freedesktop-...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-03 23:05 UTC by blinxen
Modified: 2024-08-27 20:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-27 20:10:09 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description blinxen 2024-05-03 23:05:25 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-freedesktop-desktop-entry/rust-freedesktop-desktop-entry.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-freedesktop-desktop-entry/rust-freedesktop-desktop-entry-0.5.2-1.fc41.src.rpm

Description:
Freedesktop Desktop Entry Specification.

Fedora Account System Username: blinxen

Comment 1 Fedora Review Service 2024-05-03 23:13:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7403191
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279016-rust-freedesktop-desktop-entry/fedora-rawhide-x86_64/07403191-rust-freedesktop-desktop-entry/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 wojnilowicz 2024-05-16 18:42:34 UTC
Hi, would you like to do a review swap for https://bugzilla.redhat.com/show_bug.cgi?id=2279916 ?

Comment 3 Fabio Valentini 2024-06-03 11:27:25 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have the time, it would be great if you could review one of my pending packages in return (preferably this one: https://bugzilla.redhat.com/show_bug.cgi?id=2283310).

Comment 4 blinxen 2024-08-27 20:10:09 UTC
I am not interested in this package anymore.


Note You need to log in before you can comment on or make changes to this bug.