Bug 2279536 - Review Request: rust-stringprep - Implementation of the stringprep algorithm
Summary: Review Request: rust-stringprep - Implementation of the stringprep algorithm
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/stringprep
Whiteboard:
Depends On: 2279853
Blocks: 2279542 2279544
TreeView+ depends on / blocked
 
Reported: 2024-05-07 12:06 UTC by Cristian Le
Modified: 2024-07-05 14:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-05 14:11:29 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7424552 to 7428624 (480 bytes, patch)
2024-05-09 09:33 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2024-05-07 12:09:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7424552
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279536-rust-stringprep/fedora-rawhide-x86_64/07424552-rust-stringprep/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cristian Le 2024-05-09 09:31:27 UTC
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/a76f57039357a394fcefea0fce7d16811c0102ae/rust-stringprep/rust-stringprep.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpmspec-main/fedora-rawhide-x86_64/07428590-rust-stringprep/rust-stringprep-0.1.4-1.fc41.src.rpm

rust2rpm.toml:
```toml
[[package.extra-patches]]
comments = [
    "https://github.com/sfackler/rust-stringprep/pull/9",
    "Change finl_unicode dependence to unicode-properties",
]
file = "rust-stringprep-0.1.4-Change-dependency.patch"
number = 10
```

Comment 3 Fedora Review Service 2024-05-09 09:33:39 UTC
Created attachment 2032274 [details]
The .spec file difference from Copr build 7424552 to 7428624

Comment 4 Fedora Review Service 2024-05-09 09:33:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7428624
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279536-rust-stringprep/fedora-rawhide-x86_64/07428624-rust-stringprep/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Cristian Le 2024-05-20 20:41:58 UTC
[fedora-review-service-build]

No longer blocked, but still waiting on upstream to decision to finalize: https://github.com/sfackler/rust-stringprep/pull/9

Comment 6 Fedora Review Service 2024-05-20 21:19:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7467151
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279536-rust-stringprep/fedora-rawhide-x86_64/07467151-rust-stringprep/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Robert-André Mauchin 🐧 2024-05-21 16:26:42 UTC
- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Comment 9 Cristian Le 2024-05-28 09:17:28 UTC
[fedora-review-service-build]

Comment 10 Cristian Le 2024-05-29 18:25:06 UTC
[fedora-review-service-build]

Comment 11 Fedora Admin user for bugzilla script actions 2024-07-05 13:52:33 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-stringprep

Comment 12 Fedora Update System 2024-07-05 14:06:59 UTC
FEDORA-2024-035b647589 (rust-stringprep-0.1.5-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-035b647589

Comment 13 Fedora Update System 2024-07-05 14:11:29 UTC
FEDORA-2024-035b647589 (rust-stringprep-0.1.5-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.