Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
This project is now read‑only. Starting Monday, February 2, please use https://ibm-ceph.atlassian.net/ for all bug tracking management.

Bug 2280986

Summary: cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Jos Collin <jcollin>
Component: CephFSAssignee: Jos Collin <jcollin>
Status: CLOSED CANTFIX QA Contact: Hemanth Kumar <hyelloji>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: ceph-eng-bugs, cephqe-warriors, ngangadh, sumr
Target Milestone: ---   
Target Release: 6.1z7   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: missed during coding. Consequence: sync_failures metrics was not incremented correctly. Fix: The patch increment sync_failures when sync_perms() and sync_snaps() fails. Result:
 Story Points: ---
Clone Of:
: 2280992 2280996 (view as bug list) Environment:
Last Closed: 2024-06-21 11:52:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2280992, 2280996    

Description Jos Collin 2024-05-17 15:53:33 UTC 
Description of problem:
When sync_perms() fails  _inc_failed_count() is called for incrementing the failed count. So it's better reflect that in the metrics too. Does the same for sync_snaps() too.

Version-Release number of selected component (if applicable):
RHCS6.1

How reproducible:
sync_failures metrics was not incremented correctly. 

Steps to Reproduce:
1. Create a snapshot sync failure or a permissions sync failure.
2. Check the sync_failures metrics exported value.
3. The value would be incorrect, lesser than expected value.

Actual results:
sync_failures metrics was not incremented correctly.

Expected results:
sync_failures metrics should show the correct value of snapshot sync failures.

Additional info:
Comment 1 Jos Collin 2024-06-21 11:52:53 UTC 
This cannot be backported to RHCS 6.1, as https://github.com/ceph/ceph/pull/55471 is not backported to RHCS 6.1