Bug 2280992 - cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails [NEEDINFO]
Summary: cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: CephFS
Version: 7.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: 7.0z4
Assignee: Jos Collin
QA Contact: Hemanth Kumar
URL:
Whiteboard:
Depends On: 2280986 2280996
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-17 16:17 UTC by Jos Collin
Modified: 2025-02-05 14:47 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: missed during coding. Consequence: sync_failures metrics was not incremented correctly. Fix: The patch increment sync_failures when sync_perms() and sync_snaps() fails. Result:
Clone Of: 2280986
Environment:
Last Closed: 2025-02-05 14:47:15 UTC
Embargoed:
hyelloji: needinfo? (vshankar)

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Ceph Project Bug Tracker 65980 0 None None None 2024-05-17 16:17:44 UTC
Red Hat Issue Tracker RHCEPH-9052 0 None None None 2024-05-17 16:25:40 UTC

Description Jos Collin 2024-05-17 16:17:44 UTC 
+++ This bug was initially created as a clone of Bug #2280986 +++

Description of problem:
When sync_perms() fails  _inc_failed_count() is called for incrementing the failed count. So it's better reflect that in the metrics too. Does the same for sync_snaps() too.

Version-Release number of selected component (if applicable):
RHCS6.1

How reproducible:
sync_failures metrics was not incremented correctly. 

Steps to Reproduce:
1. Create a snapshot sync failure or a permissions sync failure.
2. Check the sync_failures metrics exported value.
3. The value would be incorrect, lesser than expected value.

Actual results:
sync_failures metrics was not incremented correctly.

Expected results:
sync_failures metrics should show the correct value of snapshot sync failures.

Additional info:
Note You need to log in before you can comment on or make changes to this bug.