Spec URL: https://rathann.fedorapeople.org/review/python-steampunk-spotter/python-steampunk-spotter.spec SRPM URL: https://rathann.fedorapeople.org/review/python-steampunk-spotter/python-steampunk-spotter-3.3.0-1.fc41.src.rpm Description: Steampunk Spotter is an Ansible Playbook Platform that offers valuable insights into your playbooks to help you optimize and maximize your automation. It was created by XLAB Steampunk, an IT automation specialist and leading expert in building Enterprise Ansible Collections. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/7482993 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283066-python-steampunk-spotter/fedora-rawhide-x86_64/07482993-python-steampunk-spotter/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
Spec URL: https://rathann.fedorapeople.org/review/python-steampunk-spotter/python-steampunk-spotter.spec SRPM URL: https://rathann.fedorapeople.org/review/python-steampunk-spotter/python-steampunk-spotter-5.5.1-1.fc43.src.rpm * Sat May 24 2025 Dominik Mierzejewski <dominik> 5.5.1-1 - update to 5.5.1
Copr build: https://copr.fedorainfracloud.org/coprs/build/9077509 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283066-python-steampunk-spotter/fedora-rawhide-x86_64/09077509-python-steampunk-spotter/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 2091395 [details] The .spec file difference from Copr build 9077509 to 9077514
Copr build: https://copr.fedorainfracloud.org/coprs/build/9077514 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283066-python-steampunk-spotter/fedora-rawhide-x86_64/09077514-python-steampunk-spotter/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Some tests fail on Rawhide: ============================= test session starts ============================== platform linux -- Python 3.14.0b4, pytest-8.3.5, pluggy-1.6.0 rootdir: /builddir/build/BUILD/python-steampunk-spotter-5.5.1-build/spotter-cli-5.5.1 configfile: pyproject.toml plugins: xdist-3.7.0 collected 230 items tests/unit/spotter/test_api.py .................... [ 8%] tests/unit/spotter/test_environment.py ......................... [ 19%] tests/unit/spotter/test_parsing.py ..................................... [ 35%] ............................................ [ 54%] tests/unit/spotter/test_reporting.py ........ [ 58%] tests/unit/spotter/test_rewriting.py ...................... [ 67%] tests/unit/spotter/test_scanning.py .................................... [ 83%] FFF..... [ 86%] tests/unit/spotter/test_storage.py .............. [ 93%] tests/unit/spotter/test_utils.py ................ [100%] =================================== FAILURES =================================== _ TestScanning.test_output_formatting[YamlFormatter-True-True-True-scan_output_dict.yml] _ self = <tests.unit.spotter.test_scanning.TestScanning object at 0x7ff4acf81cc0> formatter_class = <class 'spotter.library.formatting.yaml_formatter.YamlFormatter'> docs_url = True, scan_url = True, colors = True reference_file = 'scan_output_dict.yml' @pytest.mark.parametrize( "formatter_class, docs_url, scan_url, colors, reference_file", [ (TextFormatter, True, True, True, "scan_output_full.txt"), (TextFormatter, True, True, False, "scan_output_no_colors.txt"), (TextFormatter, False, True, True, "scan_output_no_docs.txt"), (TextFormatter, True, False, True, "scan_output_no_scan_url.txt"), (TextFormatter, False, True, False, "scan_output_no_colors_no_docs.txt"), (TextFormatter, False, False, False, "scan_output_no_colors_no_docs_no_scan_url.txt"), (JsonFormatter, True, True, True, "scan_output_dict.json"), (JsonFormatter, False, True, True, "scan_output_dict_no_docs.json"), (JsonFormatter, True, False, True, "scan_output_dict_no_web_urls.json"), (YamlFormatter, True, True, True, "scan_output_dict.yml"), (YamlFormatter, False, True, True, "scan_output_dict_no_docs.yml"), (YamlFormatter, True, False, True, "scan_output_dict_no_web_urls.yml"), (JUnitFormatter, True, True, True, "scan_output_junit.xml"), (JUnitFormatter, False, True, True, "scan_output_junit_no_docs.xml"), ], ) def test_output_formatting( self, formatter_class: Type[OutputFormatter], docs_url: bool, scan_url: bool, colors: bool, reference_file: str ) -> None: output = formatter_class().format( self.TEST_SCAN_RESULT, self.TEST_PARSING_RESULT, OutputFormatOptions( show_docs_url=docs_url, show_scan_url=scan_url, show_colors=colors, rewriting_enabled=False ), ) encoding = "unicode_escape" if colors else "utf-8" with (Path("tests/unit/data/scanning/") / reference_file).open("r", encoding=encoding) as f: reference_output = f.read() > assert output == reference_output E AssertionError: assert 'uuid: VzhZjn..._type: TASK\n' == 'uuid: VzhZjn..._type: TASK\n' E E Skipping 438 identical leading characters in diff, use -v to show E + ject_url: E - ject_url: https://spotter.xlab.si/organization/organization_url/projects/proj_url/ E ? ^^^^^^^^^ E + https://spotter.xlab.si/organization/organization_url/projects/proj_url/ E ? ^^^... E E ...Full output truncated (105 lines hidden), use '-vv' to show tests/unit/spotter/test_scanning.py:851: AssertionError _ TestScanning.test_output_formatting[YamlFormatter-False-True-True-scan_output_dict_no_docs.yml] _ self = <tests.unit.spotter.test_scanning.TestScanning object at 0x7ff4acf81d60> formatter_class = <class 'spotter.library.formatting.yaml_formatter.YamlFormatter'> docs_url = False, scan_url = True, colors = True reference_file = 'scan_output_dict_no_docs.yml' @pytest.mark.parametrize( "formatter_class, docs_url, scan_url, colors, reference_file", [ (TextFormatter, True, True, True, "scan_output_full.txt"), (TextFormatter, True, True, False, "scan_output_no_colors.txt"), (TextFormatter, False, True, True, "scan_output_no_docs.txt"), (TextFormatter, True, False, True, "scan_output_no_scan_url.txt"), (TextFormatter, False, True, False, "scan_output_no_colors_no_docs.txt"), (TextFormatter, False, False, False, "scan_output_no_colors_no_docs_no_scan_url.txt"), (JsonFormatter, True, True, True, "scan_output_dict.json"), (JsonFormatter, False, True, True, "scan_output_dict_no_docs.json"), (JsonFormatter, True, False, True, "scan_output_dict_no_web_urls.json"), (YamlFormatter, True, True, True, "scan_output_dict.yml"), (YamlFormatter, False, True, True, "scan_output_dict_no_docs.yml"), (YamlFormatter, True, False, True, "scan_output_dict_no_web_urls.yml"), (JUnitFormatter, True, True, True, "scan_output_junit.xml"), (JUnitFormatter, False, True, True, "scan_output_junit_no_docs.xml"), ], ) def test_output_formatting( self, formatter_class: Type[OutputFormatter], docs_url: bool, scan_url: bool, colors: bool, reference_file: str ) -> None: output = formatter_class().format( self.TEST_SCAN_RESULT, self.TEST_PARSING_RESULT, OutputFormatOptions( show_docs_url=docs_url, show_scan_url=scan_url, show_colors=colors, rewriting_enabled=False ), ) encoding = "unicode_escape" if colors else "utf-8" with (Path("tests/unit/data/scanning/") / reference_file).open("r", encoding=encoding) as f: reference_output = f.read() > assert output == reference_output E AssertionError: assert 'uuid: VzhZjn..._type: TASK\n' == 'uuid: VzhZjn..._type: TASK\n' E E Skipping 438 identical leading characters in diff, use -v to show E + ject_url: E - ject_url: https://spotter.xlab.si/organization/organization_url/projects/proj_url/ E ? ^^^^^^^^^ E + https://spotter.xlab.si/organization/organization_url/projects/proj_url/ E ? ^^^... E E ...Full output truncated (101 lines hidden), use '-vv' to show tests/unit/spotter/test_scanning.py:851: AssertionError _ TestScanning.test_output_formatting[YamlFormatter-True-False-True-scan_output_dict_no_web_urls.yml] _ self = <tests.unit.spotter.test_scanning.TestScanning object at 0x7ff4acf81e00> formatter_class = <class 'spotter.library.formatting.yaml_formatter.YamlFormatter'> docs_url = True, scan_url = False, colors = True reference_file = 'scan_output_dict_no_web_urls.yml' @pytest.mark.parametrize( "formatter_class, docs_url, scan_url, colors, reference_file", [ (TextFormatter, True, True, True, "scan_output_full.txt"), (TextFormatter, True, True, False, "scan_output_no_colors.txt"), (TextFormatter, False, True, True, "scan_output_no_docs.txt"), (TextFormatter, True, False, True, "scan_output_no_scan_url.txt"), (TextFormatter, False, True, False, "scan_output_no_colors_no_docs.txt"), (TextFormatter, False, False, False, "scan_output_no_colors_no_docs_no_scan_url.txt"), (JsonFormatter, True, True, True, "scan_output_dict.json"), (JsonFormatter, False, True, True, "scan_output_dict_no_docs.json"), (JsonFormatter, True, False, True, "scan_output_dict_no_web_urls.json"), (YamlFormatter, True, True, True, "scan_output_dict.yml"), (YamlFormatter, False, True, True, "scan_output_dict_no_docs.yml"), (YamlFormatter, True, False, True, "scan_output_dict_no_web_urls.yml"), (JUnitFormatter, True, True, True, "scan_output_junit.xml"), (JUnitFormatter, False, True, True, "scan_output_junit_no_docs.xml"), ], ) def test_output_formatting( self, formatter_class: Type[OutputFormatter], docs_url: bool, scan_url: bool, colors: bool, reference_file: str ) -> None: output = formatter_class().format( self.TEST_SCAN_RESULT, self.TEST_PARSING_RESULT, OutputFormatOptions( show_docs_url=docs_url, show_scan_url=scan_url, show_colors=colors, rewriting_enabled=False ), ) encoding = "unicode_escape" if colors else "utf-8" with (Path("tests/unit/data/scanning/") / reference_file).open("r", encoding=encoding) as f: reference_output = f.read() > assert output == reference_output E AssertionError: assert 'uuid: VzhZjn..._type: TASK\n' == 'uuid: VzhZjn..._type: TASK\n' E E Skipping 1006 identical leading characters in diff, use -v to show E + doc_url: E - doc_url: https://docs.steampunk.si/plugins/sensu/sensu_go/1.13.2/module/user.html E ? ^^^^^^^^ E + https://docs.steampunk.si/plugins/sensu/sensu_go/1.13.2/module/user.html E ? ^^^^... E E ...Full output truncated (71 lines hidden), use '-vv' to show tests/unit/spotter/test_scanning.py:851: AssertionError =========================== short test summary info ============================ FAILED tests/unit/spotter/test_scanning.py::TestScanning::test_output_formatting[YamlFormatter-True-True-True-scan_output_dict.yml] FAILED tests/unit/spotter/test_scanning.py::TestScanning::test_output_formatting[YamlFormatter-False-True-True-scan_output_dict_no_d ocs.yml] FAILED tests/unit/spotter/test_scanning.py::TestScanning::test_output_formatting[YamlFormatter-True-False-True-scan_output_dict_no_w eb_urls.yml] ======================== 3 failed, 227 passed in 12.92s ========================
Confirmed, upstream issue opened for the failures: https://gitlab.com/xlab-steampunk/steampunk-spotter-client/spotter-cli/-/issues/405 . Spec URL: https://rathann.fedorapeople.org/review/python-steampunk-spotter/python-steampunk-spotter.spec SRPM URL: https://rathann.fedorapeople.org/review/python-steampunk-spotter/python-steampunk-spotter-5.5.1-2.fc43.src.rpm * Thu Jul 24 2025 Dominik Mierzejewski <dominik> 5.5.1-2 - skip failing output formatting tests for now - make check section idempotent
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "*No copyright* GNU General Public License, Version 3", "*No copyright* GNU General Public License". 331 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-steampunk- spotter/2283066-python-steampunk-spotter/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 29152 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-steampunk-spotter-5.5.1-2.fc43.noarch.rpm python-steampunk-spotter-5.5.1-2.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4eiyjloz')] checks: 32, packages: 2 python3-steampunk-spotter.noarch: W: no-manual-page-for-binary spotter 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-steampunk-spotter.noarch: W: no-manual-page-for-binary spotter 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 4 filtered, 0 badness; has taken 0.3 s Source checksums ---------------- https://gitlab.com/xlab-steampunk/steampunk-spotter-client/spotter-cli/-/archive/5.5.1/spotter-cli-5.5.1.tar.bz2 : CHECKSUM(SHA256) this package : d642b04e7adfe5aff94257157c941bce0666e5afa3978791f86b5d50a0d74b3b CHECKSUM(SHA256) upstream package : d642b04e7adfe5aff94257157c941bce0666e5afa3978791f86b5d50a0d74b3b Requires -------- python3-steampunk-spotter (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.14dist(colorama) python3.14dist(detect-secrets) python3.14dist(pydantic) python3.14dist(requests) python3.14dist(rich) python3.14dist(ruamel-yaml) Provides -------- python3-steampunk-spotter: python-steampunk-spotter python3-steampunk-spotter python3.14-steampunk-spotter python3.14dist(steampunk-spotter) python3dist(steampunk-spotter) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2283066 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Java, PHP, C/C++, Ocaml, fonts, Perl, R, Haskell, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) $ rpm -qL python3-steampunk-spotter-5.5.1-2.fc43.noarch.rpm /usr/lib/python3.14/site-packages/steampunk_spotter-5.5.1.dist-info/licenses/LICENSE /usr/share/licenses/python3-steampunk-spotter/LICENSE Please change %pyproject_save_files spotter to %pyproject_save_files -l spotter and renove %license LICENSE b) Approved. c) Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2374723 https://bugzilla.redhat.com/show_bug.cgi?id=2385917 https://bugzilla.redhat.com/show_bug.cgi?id=2386164 https://bugzilla.redhat.com/show_bug.cgi?id=2375219 Would be appreciated if time allows.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-steampunk-spotter
FEDORA-2025-af2279eb3d (python-steampunk-spotter-5.5.1-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-af2279eb3d
FEDORA-2025-af2279eb3d (python-steampunk-spotter-5.5.1-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-b35de67d1d (python-steampunk-spotter-5.5.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b35de67d1d
FEDORA-2025-b35de67d1d (python-steampunk-spotter-5.5.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.