Spec URL: https://gui1ty.fedorapeople.org/review/python-meshio.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-meshio-5.3.5-4.fc41.src.rpm Description: There are various mesh formats available for representing unstructured meshes. meshio can read and write all of the following and smoothly converts between them: Abaqus (.inp), ANSYS msh (.msh), AVS-UCD (.avs), CGNS (.cgns), DOLFIN XML (.xml), Exodus (.e, .exo), FLAC3D (.f3grid), H5M (.h5m), Kratos/MDPA (.mdpa), Medit (.mesh, .meshb), MED/Salome (.med), Nastran (bulk data, .bdf, .fem, .nas), Netgen (.vol, .vol.gz), Neuroglancer precomputed format, Gmsh (format versions 2.2, 4.0, and 4.1, .msh), OBJ(.obj), OFF (.off), PERMAS (.post, .post.gz, .dato, .dato.gz), PLY (.ply), STL (.stl), Tecplot .dat, TetGen .node/.ele, SVG (2D output only) (.svg), SU2 (.su2), UGRID (.ugrid), VTK (.vtk), VTU (.vtu), WKT (TIN) (.wkt), XDMF (.xdmf, .xmf). Fedora Account System Username: gui1ty
Requires: (python3-%{pypi_name}-paraview if paraview) needs to be changed to Requires: (paraview-%{pypi_name} if paraview) to match what you decided to call the Paraview plugin subpackage.
(In reply to Ben Beasley from comment #1) > Requires: (python3-%{pypi_name}-paraview if paraview) > > needs to be changed to > > Requires: (paraview-%{pypi_name} if paraview) > > to match what you decided to call the Paraview plugin subpackage. Fixed. If I remember correctly, I wasn't quite sure on what to call the ParaView plugin package. Spec URL: https://gui1ty.fedorapeople.org/review/python-meshio.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-meshio-5.3.5-5.fc41.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7700297 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283539-python-meshio/fedora-rawhide-x86_64/07700297-python-meshio/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Reviewing this now.
Looking very good. A few things to look at: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__/paraview- meshio-plugin.cpython-313.opt-1.pyc See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ^ This is fine. - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ^ False positive. - Where is README-test-files.md? - The GitHub repo, and so the Source, seems to already include the tests mesh files---is there a reason we're using a different archive/SOURCE for these instead? - Do the paraview packages also need to be split into -openmpi/-mpich sub-packages? - A few unowned directories need to be looked into. - python-meshio.spec:126: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview ^ I think this is OK, since paraview is arched but the plugin files here are not. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 197 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/2283539-python- meshio/licensecheck.txt ^ Note that no license information is included upstream for the various test mesh files. [x]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/__pycache__, /usr/lib64/paraview/paraview/plugins/meshio/__pycache__, /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__ ^ Do we need to own this directory? [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/__pycache__, /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__, /usr/lib/python3.13, /usr/lib64/paraview/paraview/plugins/meshio/__pycache__ ^ Same as above. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/mpich(mpich), /usr/lib64/mpich/lib(mpich), /usr/lib64/mpich/lib/paraview(paraview- mpich), /usr/lib64/mpich/lib/paraview/paraview(paraview-mpich), /usr/lib64/mpich/lib/paraview/paraview/plugins(paraview-mpich), /usr/lib64/openmpi(openmpi), /usr/lib64/openmpi/lib(openmpi), /usr/lib64/openmpi/lib/paraview(paraview-openmpi), /usr/lib64/openmpi/lib/paraview/paraview(paraview-openmpi), /usr/lib64/openmpi/lib/paraview/paraview/plugins(paraview-openmpi), /usr/lib64/paraview(paraview), /usr/lib64/paraview/paraview(paraview), /usr/lib64/paraview/paraview/plugins(paraview) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11543 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-meshio , paraview-meshio , python3-meshio+all [x]: Package functions as described. ^ All tests pass [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) ^ rpmautospec usage, ignore. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-meshio-5.3.5-5.fc42.noarch.rpm paraview-meshio-5.3.5-5.fc42.noarch.rpm python3-meshio+all-5.3.5-5.fc42.noarch.rpm python-meshio-5.3.5-5.fc42.src.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpapljzy96')] checks: 32, packages: 4 python-meshio.src: E: spelling-error ('Abaqus', '%description -l en_US Abaqus -> Abacus') python-meshio.src: E: spelling-error ('inp', '%description -l en_US inp -> nip, imp, in') python-meshio.src: E: spelling-error ('msh', '%description -l en_US msh -> ms, sh, mesh') python-meshio.src: E: spelling-error ('avs', '%description -l en_US avs -> abs, av, as') python-meshio.src: E: spelling-error ('cgns', '%description -l en_US cgns -> cans, cons, cosigns') python-meshio.src: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') python-meshio.src: E: spelling-error ('exo', '%description -l en_US exo -> exp, ex, exon') python-meshio.src: E: spelling-error ('mdpa', '%description -l en_US mdpa -> mudpack') python-meshio.src: E: spelling-error ('meshb', '%description -l en_US meshb -> mesh, mesh b') python-meshio.src: E: spelling-error ('bdf', '%description -l en_US bdf -> bf, PDF') python-meshio.src: E: spelling-error ('nas', '%description -l en_US nas -> ans, mas, as') python-meshio.src: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') python-meshio.src: E: spelling-error ('precomputed', '%description -l en_US precomputed -> recomputed, p recomputed, computerized') python-meshio.src: E: spelling-error ('dato', '%description -l en_US dato -> date, data, dado') python-meshio.src: E: spelling-error ('stl', '%description -l en_US stl -> st, sol, std') python-meshio.src: E: spelling-error ('dat', '%description -l en_US dat -> DAT, tad, sat') python-meshio.src: E: spelling-error ('ele', '%description -l en_US ele -> lee, eel, eke') python-meshio.src: E: spelling-error ('svg', '%description -l en_US svg -> avg, sag, SVN') python-meshio.src: E: spelling-error ('ugrid', '%description -l en_US ugrid -> grid, u grid') python-meshio.src: E: spelling-error ('vtk', '%description -l en_US vtk -> VT') python-meshio.src: E: spelling-error ('vtu', '%description -l en_US vtu -> Stu, Btu, VT') python-meshio.src: E: spelling-error ('wkt', '%description -l en_US wkt -> wk, wt, kt') python-meshio.src: E: spelling-error ('xdmf', '%description -l en_US xdmf -> admix') python-meshio.src: E: spelling-error ('xmf', '%description -l en_US xmf -> emf, XML') python3-meshio+all.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-meshio+all.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-meshio.noarch: E: spelling-error ('inp', '%description -l en_US inp -> nip, imp, in') python3-meshio.noarch: E: spelling-error ('msh', '%description -l en_US msh -> ms, sh, mesh') python3-meshio.noarch: E: spelling-error ('avs', '%description -l en_US avs -> abs, av, as') python3-meshio.noarch: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') python3-meshio.noarch: E: spelling-error ('exo', '%description -l en_US exo -> exp, ex, exon') python3-meshio.noarch: E: spelling-error ('meshb', '%description -l en_US meshb -> mesh, mesh b') python3-meshio.noarch: E: spelling-error ('bdf', '%description -l en_US bdf -> bf, PDF') python3-meshio.noarch: E: spelling-error ('nas', '%description -l en_US nas -> ans, mas, as') python3-meshio.noarch: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') python3-meshio.noarch: E: spelling-error ('precomputed', '%description -l en_US precomputed -> recomputed, p recomputed, computerized') python3-meshio.noarch: E: spelling-error ('dato', '%description -l en_US dato -> date, data, dado') python3-meshio.noarch: E: spelling-error ('dat', '%description -l en_US dat -> DAT, tad, sat') python3-meshio.noarch: E: spelling-error ('ele', '%description -l en_US ele -> lee, eel, eke') python3-meshio.noarch: E: spelling-error ('xmf', '%description -l en_US xmf -> emf, XML') paraview-meshio.noarch: W: only-non-binary-in-usr-lib paraview-meshio.noarch: E: noarch-with-lib64 paraview-meshio.noarch: W: no-documentation python3-meshio+all.noarch: W: no-documentation python-meshio.spec:126: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview python-meshio.spec:127: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview/paraview python-meshio.spec:128: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview/paraview/plugins python-meshio.spec:129: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview/paraview/plugins/%{pypi_name} python-meshio.spec:130: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %pycached %{_libdir}/paraview/paraview/plugins/%{pypi_name}/paraview-meshio-plugin.py python-meshio.spec:133: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich python-meshio.spec:134: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib python-meshio.spec:135: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview python-meshio.spec:136: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview/paraview python-meshio.spec:137: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview/paraview/plugins python-meshio.spec:138: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview/paraview/plugins/%{pypi_name} python-meshio.spec:139: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %pycached %{_libdir}/mpich/lib/paraview/paraview/plugins/%{pypi_name}/paraview-meshio-plugin.py python-meshio.spec:142: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi python-meshio.spec:143: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib python-meshio.spec:144: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview python-meshio.spec:145: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview/paraview python-meshio.spec:146: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview/paraview/plugins python-meshio.spec:147: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview/paraview/plugins/%{pypi_name} python-meshio.spec:148: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %pycached %{_libdir}/openmpi/lib/paraview/paraview/plugins/%{pypi_name}/paraview-meshio-plugin.py python-meshio.spec: W: invalid-url Source1: meshio-test-files-5.3.5.tar.gz paraview-meshio.noarch: W: files-duplicate /usr/lib64/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py:/usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py ============================================ 4 packages and 0 specfiles checked; 41 errors, 24 warnings, 31 filtered, 41 badness; has taken 0.7 s ============================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 python3-meshio+all.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-meshio+all.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-meshio.noarch: E: spelling-error ('inp', '%description -l en_US inp -> nip, imp, in') python3-meshio.noarch: E: spelling-error ('msh', '%description -l en_US msh -> ms, sh, mesh') python3-meshio.noarch: E: spelling-error ('avs', '%description -l en_US avs -> abs, av, as') python3-meshio.noarch: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') python3-meshio.noarch: E: spelling-error ('exo', '%description -l en_US exo -> exp, ex, exon') python3-meshio.noarch: E: spelling-error ('meshb', '%description -l en_US meshb -> mesh, mesh b') python3-meshio.noarch: E: spelling-error ('bdf', '%description -l en_US bdf -> bf, PDF') python3-meshio.noarch: E: spelling-error ('nas', '%description -l en_US nas -> ans, mas, as') python3-meshio.noarch: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') python3-meshio.noarch: E: spelling-error ('precomputed', '%description -l en_US precomputed -> recomputed, p recomputed, computerized') python3-meshio.noarch: E: spelling-error ('dato', '%description -l en_US dato -> date, data, dado') python3-meshio.noarch: E: spelling-error ('dat', '%description -l en_US dat -> DAT, tad, sat') python3-meshio.noarch: E: spelling-error ('ele', '%description -l en_US ele -> lee, eel, eke') python3-meshio.noarch: E: spelling-error ('xmf', '%description -l en_US xmf -> emf, XML') paraview-meshio.noarch: W: only-non-binary-in-usr-lib paraview-meshio.noarch: E: noarch-with-lib64 python3-meshio+all.noarch: W: no-documentation paraview-meshio.noarch: W: no-documentation paraview-meshio.noarch: W: files-duplicate /usr/lib64/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py:/usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py 3 packages and 0 specfiles checked; 17 errors, 4 warnings, 27 filtered, 17 badness; has taken 0.3 s Source checksums ---------------- https://github.com/nschloe/meshio/archive/v5.3.5/meshio-5.3.5.tar.gz : CHECKSUM(SHA256) this package : 9e05d217857138d8f731803366c67acea2cfd67b0dd5aebe0281f1fb13ba57e5 CHECKSUM(SHA256) upstream package : 9e05d217857138d8f731803366c67acea2cfd67b0dd5aebe0281f1fb13ba57e5 Requires -------- python3-meshio (rpmlib, GLIBC filtered): (paraview-meshio if paraview) /usr/bin/python3 python(abi) python3.13dist(numpy) python3.13dist(rich) paraview-meshio (rpmlib, GLIBC filtered): paraview python3-meshio python3-meshio+all (rpmlib, GLIBC filtered): python(abi) python3-meshio python3.13dist(h5py) python3.13dist(netcdf4) Provides -------- python3-meshio: python-meshio python3-meshio python3.13-meshio python3.13dist(meshio) python3dist(meshio) paraview-meshio: paraview-meshio python3-meshio+all: python-meshio+all python3-meshio+all python3.13-meshio+all python3.13dist(meshio[all]) python3dist(meshio[all]) Diff spec file in url and in SRPM --------------------------------- --- /home/asinha/dump/fedora-reviews/2283539-python-meshio/srpm/python-meshio.spec 2024-09-11 11:40:43.911174180 +0100 +++ /home/asinha/dump/fedora-reviews/2283539-python-meshio/srpm-unpacked/python-meshio.spec 2024-07-03 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 5; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global pypi_name meshio @@ -140,3 +150,18 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jul 03 2024 Sandro <devel> - 5.3.5-5 +- Fix Requires + +* Tue May 28 2024 Sandro <devel> - 5.3.5-4 +- Add ParaView plugin + +* Mon May 27 2024 Sandro <devel> - 5.3.5-3 +- Add test files + +* Mon May 27 2024 Sandro <devel> - 5.3.5-2 +- Add man pages + +* Mon May 27 2024 Sandro <devel> - 5.3.5-1 +- Initial package +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2283539 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: C/C++, R, Ocaml, SugarActivity, PHP, Perl, Java, fonts, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> - Do the paraview packages also need to be split into -openmpi/-mpich sub-packages? I think that there is little reason to split the paraview plugins, because it’s small (in file size and number of files), and more importantly it doesn’t depend on any of the MPI implementations, so we can install all three versions/copies of the paraview plugin without dragging in any extra dependencies. If the plugin linked the MPI libraries, it would be different.
> - python-meshio.spec:126: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview > ^ > I think this is OK, since paraview is arched but the plugin files here are not. This does need fixing since %{_libdir} may be either /usr/lib or /usr/lib64 depending on architecture. Even though the files are arch-independent, the paths are not. The base package will have to become arched, and then we can make python3-meshio noarch – and we can also pass "-a" to %pyproject_extras_subpkg to make the extras metapackages noarch.
> Note: No known owner of > /usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/__pycache__, > /usr/lib64/paraview/paraview/plugins/meshio/__pycache__, > /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__ > > ^ > Do we need to own this directory? Yes, we need %dir %{_libdir}/paraview/paraview/plugins/%{pypi_name}/__pycache__ and similarly for the other two paraview plugin directories.
(In reply to Ankur Sinha (FranciscoD) from comment #5) > Looking very good. A few things to look at: Thank you for reviewing. I comment inline below. > - Where is README-test-files.md? That will be in dist-git once the package is approved. I uploaded it to: https://gui1ty.fedorapeople.org/review/README-test-files.md I should have done that before or attached the file to the review request, since it answers the questions regarding the test files and why an additional source is required and how I obtained it. > - The GitHub repo, and so the Source, seems to already include the tests > mesh files---is there a reason we're using a different archive/SOURCE for > these instead? I believe the answer is in README-test-files.md (see above). > - Do the paraview packages also need to be split into -openmpi/-mpich > sub-packages? See my response to Ben's remark below. > - A few unowned directories need to be looked into. Again, since Ben already commented on that, see my reply below. > - python-meshio.spec:126: W: libdir-macro-in-noarch-package > paraview-%{pypi_name} %dir %{_libdir}/paraview > ^ > I think this is OK, since paraview is arched but the plugin files here are > not. Yep. It's just where ParaView is looking for plugins. Annoying, but save to ignore. But the arch part needs fixing as Ben pointed out. (In reply to Ben Beasley from comment #6) > > - Do the paraview packages also need to be split into -openmpi/-mpich sub-packages? > > I think that there is little reason to split the paraview plugins, because > it’s small (in file size and number of files), and more importantly it > doesn’t depend on any of the MPI implementations, so we can install all > three versions/copies of the paraview plugin without dragging in any extra > dependencies. If the plugin linked the MPI libraries, it would be different. I agree. The plugin itself doesn't depend on MPI. It's simply for enabling ParaView to handle additional file formats. In addition to above, it keeps things simple(r) with regards to detecting if ParaView is installed. Though, on revisiting the spec file, this needs fixing. More on that below. (In reply to Ben Beasley from comment #7) > > - python-meshio.spec:126: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview > > ^ > > I think this is OK, since paraview is arched but the plugin files here are not. > > This does need fixing since %{_libdir} may be either /usr/lib or /usr/lib64 > depending on architecture. Even though the files are arch-independent, the > paths are not. The base package will have to become arched, and then we can > make python3-meshio noarch – and we can also pass "-a" to > %pyproject_extras_subpkg to make the extras metapackages noarch. Thanks. I'll implement that. (In reply to Ben Beasley from comment #8) > > Note: No known owner of > > /usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/__pycache__, > > /usr/lib64/paraview/paraview/plugins/meshio/__pycache__, > > /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__ > > > > ^ > > Do we need to own this directory? > > Yes, we need > > %dir %{_libdir}/paraview/paraview/plugins/%{pypi_name}/__pycache__ > > and similarly for the other two paraview plugin directories. I believe that will be handled by `%pycached` once the plugin is arched as you pointed out above. Though, I might be misunderstanding the macro[1]. It's the first time I'm using it. Thank you, Ben, for all your input. It's much appreciated. As mentioned above, revisiting the spec file, I believe the following line will not work: Requires: (paraview-%{pypi_name} if paraview) I looked at the MPI flavored packages and they do not depend on it as I initially thought. However, all flavors do depend on `paraview-data`. So, I will be changing that to: Recommends: (paraview-%{pypi_name} if paraview-data) I believe using `Recommends` makes it clearer that the plugin is optional. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include
(In reply to Sandro from comment #9) > As mentioned above, revisiting the spec file, I believe the following line > will not work: > > Requires: (paraview-%{pypi_name} if paraview) > > I looked at the MPI flavored packages and they do not depend on it as I > initially thought. However, all flavors do depend on `paraview-data`. So, I > will be changing that to: > > Recommends: (paraview-%{pypi_name} if paraview-data) > > I believe using `Recommends` makes it clearer that the plugin is optional. This turns out to be more tricky than I had hoped. In the paraview-meshio sub package, I have: Requires: paraview This is wrong for the same reasons as above. But here I don't see a common ground. It would need to be something along the lines of: Requires: (paraview%{?_isa} or paraview-mpich%{?_isa} or paraview-openmpi%{?_isa}) That would do the right thing if any flavor of ParaView is already installed. But what would happen if someone decided to install the plugin with `dnf install paraview-meshio`? Maybe more a corner case, but I'm intrigued nonetheless.
Nevermind. I turns out things aren't all that complicated, though a bit tricky nonetheless. It turns out `paraview-data` requires `paraview`. So, `paraview` _and_ `paraview-data` will always be installed for any of the flavors. By extension, I think it is fine to have the plugin require `paraview` as was already the case in the spec file.
> I believe that will be handled by `%pycached` once the plugin is arched as > you pointed out above. Though, I might be misunderstanding the macro[1]. > It's the first time I'm using it. The macro only habdles the files, not the plugin's `__pycache__` dir. I added that now and made the base package arched. Spec URL: https://gui1ty.fedorapeople.org/review/python-meshio.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-meshio-5.3.5-6.fc42.src.rpm
Created attachment 2046436 [details] The .spec file difference from Copr build 7700297 to 8010437
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010437 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283539-python-meshio/fedora-rawhide-x86_64/08010437-python-meshio/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Cool, this looks good now. XXX APPROVED XXX
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-meshio
FEDORA-2024-26eae5f3d8 (python-meshio-5.3.5-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-26eae5f3d8
FEDORA-2024-26eae5f3d8 (python-meshio-5.3.5-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-cd09de4377 (python-meshio-5.3.5-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cd09de4377
FEDORA-2024-dcca79e199 (python-meshio-5.3.5-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-dcca79e199
FEDORA-2024-6559d38c9a has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6559d38c9a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6559d38c9a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-cd09de4377 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-cd09de4377 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-cd09de4377 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-dcca79e199 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-dcca79e199 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-dcca79e199 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-6559d38c9a (python-meshio-5.3.5-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-dcca79e199 (python-meshio-5.3.5-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-cd09de4377 (python-meshio-5.3.5-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.