Spec URL: https://raw.githubusercontent.com/LecrisUT/rust-metris-rpmspec/18bb026c3e9d3de4cfbc75fe92babea0b3506a81/rust-metrics/rust-metrics.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500440-rust-metrics/rust-metrics-0.23.0-1.fc41.src.rpm Description: Dependency for `atuin` Fedora Account System Username: lecris rust2rpm.toml ```toml [requires] build = [ "tomcli", ] [scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ] ```
Hi, would you like to swap a review for a review at https://bugzilla.redhat.com/show_bug.cgi?id=2283042 ?
Sure I don't know the procedure for making a formal review, but I should at least do non-binding ones more often. Probably can't sit down for it until the weekend though
Ok, you've posted for a swap review at https://discussion.fedoraproject.org/t/rust-metrics-and-rust-metrics-exporter-prometheus/118255 so I assume you know how to do a formal review. If not, then no problem, and I'll be searching/waiting for somebody to appear.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review, Fabio
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-metrics
FEDORA-2024-1c1da1c6a8 (rust-metrics-0.23.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1c1da1c6a8
FEDORA-2024-876106ce14 (rust-metrics-0.23.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-876106ce14
FEDORA-2024-18900f86d1 (rust-metrics-0.23.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-18900f86d1
FEDORA-2024-1c1da1c6a8 (rust-metrics-0.23.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-876106ce14 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-876106ce14 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-876106ce14 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-18900f86d1 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-18900f86d1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-18900f86d1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-18900f86d1 (rust-metrics-0.23.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-876106ce14 (rust-metrics-0.23.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.