Bug 2284460 - Review Request: python-annarchy - Artificial Neural Networks architect
Summary: Review Request: python-annarchy - Artificial Neural Networks architect
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Felix Wang
QA Contact: Fedora Extras Quality Assurance
URL: https://annarchy.github.io/
Whiteboard:
Depends On:
Blocks: fedora-neuro, NeuroFedora
TreeView+ depends on / blocked
 
Reported: 2024-06-03 11:39 UTC by Sandro
Modified: 2024-06-16 14:47 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-06 11:21:08 UTC
Type: ---
Embargoed:
topazus: fedora-review+


Attachments (Terms of Use)

Description Sandro 2024-06-03 11:39:13 UTC
Spec URL: https://gui1ty.fedorapeople.org/review/python-annarchy.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-annarchy-4.8.0.2-1.fc41.src.rpm

Description:

ANNarchy 🏴 (Artificial Neural Networks architect) is a parallel and
hybrid simulator for distributed rate-coded or spiking neural networks.
The core of the library is written in C++ and distributed using OpenMP
or CUDA. It provides an interface in Python for the definition of the
networks.

NOTE: Since CUDA support requires proprietary Nvidia drivers, this
package only supports OpenMP and single thread.

Fedora Account System Username: gui1ty

Comment 1 Felix Wang 2024-06-04 11:27:37 UTC
1) the tests on ppc64le failed, https://copr.fedorainfracloud.org/coprs/topazus/test-review/build/7527702/

2) There are files in ANNarchy/include directory, which are under GPL-3.0-or-later license.

> License:        GPL-2.0-or-later AND MIT

3) The -devel sub-package is not packaged with header files, it is in python3-annarchy.

> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/BSRInvMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/BSRMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/BSRMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/COOMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/COOMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrixCUDAT.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrixT.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DenseMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DenseMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DenseMatrixOffsets.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DiaMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLRMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLRMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/HYBMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/HYBMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/LILInvMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/LILMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/PartitionedMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/SELLMatrix.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/SELLMatrixCUDA.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/Specific.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/VecTransformation.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/helper_functions.hpp
> python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/thirdparty/randutils.hpp

---


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

C/C++:
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "*No copyright* GNU General Public License v2.0 or later", "GNU
     General Public License v3.0 or later", "CeCILL License and/or GNU
     General Public License, Version 2", "MIT License". 50 files have
     unknown license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/python-annarchy/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/python3.12/site-packages,
     /usr/lib64, /usr/src/debug, /usr/share, /usr/src, /usr/lib,
     /usr/lib64/python3.12, /usr/share/doc, /usr
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.12/site-
     packages, /usr/lib64, /usr/src/debug, /usr/share, /usr/src,
     /usr/share/doc, /usr, /usr/lib, /usr/lib64/python3.12
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 28704 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-annarchy
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-annarchy-4.8.0.2-1.fc41.x86_64.rpm
          python-annarchy-debugsource-4.8.0.2-1.fc41.x86_64.rpm
          python-annarchy-4.8.0.2-1.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_mortjbk')]
checks: 32, packages: 3

python3-annarchy.x86_64: E: zero-length /usr/lib64/python3.12/site-packages/ANNarchy/cython_ext/__init__.pxd
python-annarchy.src: E: spelling-error ('üè', '%description -l en_US üè ')
python3-annarchy.x86_64: E: spelling-error ('üè', '%description -l en_US üè ')
python-annarchy.spec: W: patch-not-applied Patch0: %{forgeurl}/pull/22.patch
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/BSRInvMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/BSRMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/BSRMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/COOMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/COOMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrixCUDAT.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRCMatrixT.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/CSRMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DenseMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DenseMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DenseMatrixOffsets.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/DiaMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLRMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/ELLRMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/HYBMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/HYBMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/LILInvMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/LILMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/PartitionedMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/SELLMatrix.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/SELLMatrixCUDA.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/Specific.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/VecTransformation.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/include/helper_functions.hpp
python3-annarchy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.12/site-packages/ANNarchy/thirdparty/randutils.hpp
 3 packages and 0 specfiles checked; 3 errors, 31 warnings, 18 filtered, 3 badness; has taken 0.8 s 




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "python3-annarchy".
(none): E: there is no installed rpm "python-annarchy-debugsource".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Unversioned so-files
--------------------
python3-annarchy: /usr/lib64/python3.12/site-packages/ANNarchy/cython_ext/Connector.cpython-312-x86_64-linux-gnu.so
python3-annarchy: /usr/lib64/python3.12/site-packages/ANNarchy/cython_ext/Coordinates.cpython-312-x86_64-linux-gnu.so
python3-annarchy: /usr/lib64/python3.12/site-packages/ANNarchy/cython_ext/Transformations.cpython-312-x86_64-linux-gnu.so

Source checksums
----------------
https://github.com/ANNarchy/ANNarchy/archive/4.8.0.2/ANNarchy-4.8.0.2.tar.gz :
  CHECKSUM(SHA256) this package     : f5ec1df3d11cafc3611290eef8d9ef0eb98469c4195f22ce43cb71b4ac66e343
  CHECKSUM(SHA256) upstream package : f5ec1df3d11cafc3611290eef8d9ef0eb98469c4195f22ce43cb71b4ac66e343


Requires
--------
python3-annarchy (rpmlib, GLIBC filtered):
    (flexiblas-openblas-openmp or openblas-openmp)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    python(abi)
    python3.12dist(cython)
    python3.12dist(matplotlib)
    python3.12dist(numpy)
    python3.12dist(scipy)
    python3.12dist(setuptools)
    python3.12dist(sympy)
    python3.12dist(tqdm)
    rtld(GNU_HASH)

python-annarchy-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-annarchy:
    python-annarchy
    python3-annarchy
    python3-annarchy(x86-64)
    python3.12-annarchy
    python3.12dist(annarchy)
    python3dist(annarchy)

python-annarchy-debugsource:
    python-annarchy-debugsource
    python-annarchy-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-annarchy --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: fonts, PHP, Java, Ocaml, R, SugarActivity, Perl, Haskell, C/C++
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 2 Sandro 2024-06-04 13:10:08 UTC
Thank you for the points raised.

(In reply to Felix Wang from comment #1)
> 1) the tests on ppc64le failed,
> https://copr.fedorainfracloud.org/coprs/topazus/test-review/build/7527702/

So far, I only built the package on x86_64. I will check with upstream regarding support for ppc64le.

> 2) There are files in ANNarchy/include directory, which are under
> GPL-3.0-or-later license.
> 
> > License:        GPL-2.0-or-later AND MIT

Right. Changing the license string is easy. But that leaves us without the license text for GPL-3.0-or-later. I'll ask upstream why they have mixed preambles in the header files.

> 
> 3) The -devel sub-package is not packaged with header files, it is in
> python3-annarchy.

I'm aware. However, I think that is acceptable for Python packages. At least `numpy` is doing the same. And I'm not aware of any arched Python packages shipping devel sub packages.

With regards to `numpy`, it seems to be required for the header files to be shipped and installed the way they are. There is a function for getting the include path, `numpy.get_include()`, which returns `/usr/lib64/python3.12/site-packages/numpy/core/include`.

Comment 3 Sandro 2024-06-04 13:16:03 UTC
(In reply to Felix Wang from comment #1)
> 3) The -devel sub-package is not packaged with header files, it is in
> python3-annarchy.

I just noticed that I forgot to clean up the declaration of the devel sub package. While packaging I played around with what would be required to ship the header files as part of a devel sub package. However, I abandoned that approach for the reasons given above.

It will be removed in the next update after the license situation has been clarified and possibly the issue regarding ppc64le.

Comment 4 Beck Liu 2024-06-04 15:30:49 UTC
> Right. Changing the license string is easy. But that leaves us without the license text for GPL-3.0-or-later. I'll ask upstream why they have mixed preambles in the header files.

The MIT license txt file seems also missing.

> It will be removed in the next update after the license situation has been clarified and possibly the issue regarding ppc64le.

Ok, I see.

Comment 5 Sandro 2024-06-05 13:11:01 UTC
(In reply to Beck Liu from comment #4)
> > Right. Changing the license string is easy. But that leaves us without the license text for GPL-3.0-or-later. I'll ask upstream why they have mixed preambles in the header files.
> 
> The MIT license txt file seems also missing.

That's not required. Adding 'MIT' to the license field is sufficient.

Upstream has fixed the header files with regards to the license preambles.

I excluded `ppc64le` for now while I look into what could be the issue here. I'll report it upstream once I know more.

I also fixed the spec file regarding the leftover devel sub package.

Spec URL: https://gui1ty.fedorapeople.org/review/python-annarchy.spec
SRPM URL: https://gui1ty.fedorapeople.org/review/python-annarchy-4.8.0.2-2.fc41.src.rpm

Comment 6 Fedora Review Service 2024-06-05 13:40:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7532454
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284460-python-annarchy/fedora-rawhide-x86_64/07532454-python-annarchy/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Felix Wang 2024-06-06 06:08:27 UTC
> Upstream has fixed the header files with regards to the license preambles.

After looking into the issue of https://github.com/ANNarchy/ANNarchy/issues/24, the header files are currently under GPL-2.0-or-later


[x] package name is OK
[x] license is acceptable for Fedora: GPL-2.0-or-later AND MIT
[x] builds and installs OK
[x] BR/P/R look correct
[x] The package runs tests in %check.
[x] The package is using pyproject related macros.

The package is approved.

Comment 8 Fedora Admin user for bugzilla script actions 2024-06-06 08:21:38 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-annarchy

Comment 9 Fedora Update System 2024-06-06 11:18:23 UTC
FEDORA-2024-d8bf2f0a34 (python-annarchy-4.8.0.2-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8bf2f0a34

Comment 10 Fedora Update System 2024-06-06 11:18:24 UTC
FEDORA-2024-67c670c25f (python-annarchy-4.8.0.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-67c670c25f

Comment 12 Fedora Update System 2024-06-07 01:51:30 UTC
FEDORA-2024-d8bf2f0a34 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d8bf2f0a34 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8bf2f0a34

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-06-08 03:34:35 UTC
FEDORA-2024-67c670c25f has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-67c670c25f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-67c670c25f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-06-15 04:44:45 UTC
FEDORA-2024-d8bf2f0a34 (python-annarchy-4.8.0.2-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-06-16 14:47:20 UTC
FEDORA-2024-67c670c25f (python-annarchy-4.8.0.2-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.