Spec URL: https://jsteffan.fedorapeople.org/envision/rust-libusb1-sys.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-libusb1-sys-0.7.0-1.fc39/rust-libusb1-sys-0.7.0-1.fc40.src.rpm Description: FFI bindings for libusb Fedora Account System Username: jsteffan
Copr build: https://copr.fedorainfracloud.org/coprs/build/7617808 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292544-rust-libusb1-sys/fedora-rawhide-x86_64/07617808-rust-libusb1-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
APPROVED The few warnings appear to be generic rust detritus. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/libusb1-sys-0.7.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]". 41 files have unknown license. Detailed output of licensecheck in /home/whot/tmp/2024-06-25-Tue/2292544-rust- libusb1-sys/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- libusb1-sys-devel , rust-libusb1-sys+default-devel , rust- libusb1-sys+vendored-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-libusb1-sys-devel-0.7.0-1.fc41.noarch.rpm rust-libusb1-sys+default-devel-0.7.0-1.fc41.noarch.rpm rust-libusb1-sys+vendored-devel-0.7.0-1.fc41.noarch.rpm rust-libusb1-sys-0.7.0-1.fc41.src.rpm =================================================================================================================================================================== rpmlint session starts ================================================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpruhk8bqz')] checks: 32, packages: 4 rust-libusb1-sys+default-devel.noarch: W: no-documentation rust-libusb1-sys+vendored-devel.noarch: W: no-documentation rust-libusb1-sys-devel.noarch: E: incorrect-fsf-address /usr/share/cargo/registry/libusb1-sys-0.7.0/libusb/msvc/getopt/getopt.h rust-libusb1-sys-devel.noarch: E: incorrect-fsf-address /usr/share/cargo/registry/libusb1-sys-0.7.0/libusb/msvc/getopt/getopt1.c rust-libusb1-sys-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/libusb1-sys-0.7.0/libusb/msvc/.gitattributes ============================================================================================================================= 4 packages and 0 specfiles checked; 2 errors, 3 warnings, 17 filtered, 2 badness; has taken 0.4 s ============================================================================================================================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 rust-libusb1-sys+vendored-devel.noarch: W: no-documentation rust-libusb1-sys+default-devel.noarch: W: no-documentation rust-libusb1-sys-devel.noarch: E: incorrect-fsf-address /usr/share/cargo/registry/libusb1-sys-0.7.0/libusb/msvc/getopt/getopt.h rust-libusb1-sys-devel.noarch: E: incorrect-fsf-address /usr/share/cargo/registry/libusb1-sys-0.7.0/libusb/msvc/getopt/getopt1.c rust-libusb1-sys-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/libusb1-sys-0.7.0/libusb/msvc/.gitattributes 3 packages and 0 specfiles checked; 2 errors, 3 warnings, 13 filtered, 2 badness; has taken 0.2 s Source checksums ---------------- https://crates.io/api/v1/crates/libusb1-sys/0.7.0/download#/libusb1-sys-0.7.0.crate : CHECKSUM(SHA256) this package : da050ade7ac4ff1ba5379af847a10a10a8e284181e060105bf8d86960ce9ce0f CHECKSUM(SHA256) upstream package : da050ade7ac4ff1ba5379af847a10a10a8e284181e060105bf8d86960ce9ce0f Requires -------- rust-libusb1-sys-devel (rpmlib, GLIBC filtered): (crate(cc/default) >= 1.0.0 with crate(cc/default) < 2.0.0~) (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~) (crate(pkg-config/default) >= 0.3.0 with crate(pkg-config/default) < 0.4.0~) cargo rust-libusb1-sys+default-devel (rpmlib, GLIBC filtered): cargo crate(libusb1-sys) rust-libusb1-sys+vendored-devel (rpmlib, GLIBC filtered): cargo crate(libusb1-sys) Provides -------- rust-libusb1-sys-devel: crate(libusb1-sys) rust-libusb1-sys-devel rust-libusb1-sys+default-devel: crate(libusb1-sys/default) rust-libusb1-sys+default-devel rust-libusb1-sys+vendored-devel: crate(libusb1-sys/vendored) rust-libusb1-sys+vendored-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2292544 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, PHP, R, Ocaml, fonts, SugarActivity, Python, Java, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libusb1-sys
FEDORA-2024-37d807ac7d (rust-libusb1-sys-0.7.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-37d807ac7d
Small RFE: Please drop the vendored libusb sources and remove the "vendored" feature. No package in Fedora should use this. Doing `rm -r libusb` at the end of `%prep` should be enough for the former, and you can use a rust2rpm setting to hide the "vendored" feature.
FEDORA-2024-37d807ac7d (rust-libusb1-sys-0.7.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
Ha, and of course I was just working on this. How does this look? ``` diff --git a/rust-libusb1-sys.spec b/rust-libusb1-sys.spec index 3c1af95..2397950 100644 --- a/rust-libusb1-sys.spec +++ b/rust-libusb1-sys.spec @@ -51,18 +51,6 @@ use the "default" feature of the "%{crate}" crate. %files -n %{name}+default-devel %ghost %{crate_instdir}/Cargo.toml -%package -n %{name}+vendored-devel -Summary: %{summary} -BuildArch: noarch - -%description -n %{name}+vendored-devel %{_description} - -This package contains library source intended for building other packages which -use the "vendored" feature of the "%{crate}" crate. - -%files -n %{name}+vendored-devel -%ghost %{crate_instdir}/Cargo.toml - %prep %autosetup -n %{crate}-%{version} -p1 %cargo_prep @@ -70,6 +58,9 @@ use the "vendored" feature of the "%{crate}" crate. %generate_buildrequires %cargo_generate_buildrequires +# Remove vendored +rm -r libusb + %build %cargo_build ```
You added the "rm" at the end of the %generate_buildrequires scriptlet, but you need to add it at the end of %prep. Other than that, looks good.
Yup, as soon as did a mockbuild that was apparent. I also had to remove the COPYING from -devel that no longer exists. Thanks for spotting this. https://koji.fedoraproject.org/koji/taskinfo?taskID=119659685