Spec URL: https://jsteffan.fedorapeople.org/envision/rust-rusb.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-rusb-0.9.4-1.fc39/rust-rusb-0.9.4-1.fc40.src.rpm Description: Rust library for accessing USB devices Fedora Account System Username: jsteffan
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/7662186 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292550-rust-rusb/fedora-rawhide-x86_64/07662186-rust-rusb/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I think the comments from #2292544 regarding the vendored-devel package apply here too?
I've removed the vendored and added the needed BR. Spec URL: https://jsteffan.fedorapeople.org/envision/rust-rusb.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-rusb-0.9.4-1.fc39/rust-rusb-0.9.4-1.fc40.src.rpm
Created attachment 2038397 [details] The .spec file difference from Copr build 7662186 to 7677645
Copr build: https://copr.fedorainfracloud.org/coprs/build/7677645 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292550-rust-rusb/fedora-rawhide-x86_64/07677645-rust-rusb/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7690098 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292550-rust-rusb/fedora-rawhide-x86_64/07690098-rust-rusb/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
We are now waiting for `crate(libusb1-sys/default)` to hit the rawhide repo. It was included in the latest compose but is not yet in the repos (or the cache for fedora-review-service hasn't expired or sync'd yet).
Copr build: https://copr.fedorainfracloud.org/coprs/build/7694647 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292550-rust-rusb/fedora-rawhide-x86_64/07694647-rust-rusb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> BuildRequires: pkgconfig(libusb-1.0) This should not be necessary if the correct Requires are present in rust-libusb1-sys. And indeed, the Requires is missing there. You can add a rust2rpm.toml config file to rust-libusb1-sys like this one: ``` [requires] build = ["pkgconfig(libusb-1.0"] lib = ["pkgconfig(libusb-1.0"] ``` This will add the dependency on pkgconfig(libusb-1.0) as both BuildRequires and Requires in the -devel subpackage.
Ugh, typos. This should have been: ``` [requires] build = ["pkgconfig(libusb-1.0)"] lib = ["pkgconfig(libusb-1.0)"] ```
https://bodhi.fedoraproject.org/updates/FEDORA-2024-404cce887d
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-rusb.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-rusb-0.9.4-1.fc39/rust-rusb-0.9.4-1.fc40.src.rpm
Perfect. Looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rusb
FEDORA-2024-033f6bd2dd (rust-rusb-0.9.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-033f6bd2dd
FEDORA-2024-033f6bd2dd (rust-rusb-0.9.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
I used fedora-sig-onboard, very convenient.
Need karma on the following so I can build for f40 and f39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9759a91403 https://bodhi.fedoraproject.org/updates/FEDORA-2024-da1c65b4b2