Bug 2294817 - Review Request: rust-version-track - Library used to track changes to complex data
Summary: Review Request: rust-version-track - Library used to track changes to complex...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/version-track
Whiteboard:
Depends On:
Blocks: 2295731
TreeView+ depends on / blocked
 
Reported: 2024-06-30 14:50 UTC by Benjamin Gilbert
Modified: 2024-07-04 04:39 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-03 22:29:33 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Benjamin Gilbert 2024-06-30 14:50:15 UTC
Spec URL: https://fedorapeople.org/~bgilbert/srpm/rust-version-track.spec
SRPM URL: https://fedorapeople.org/~bgilbert/srpm/rust-version-track-0.1.0-1.fc40.src.rpm
Description: Library used to track changes to complex data, when direct comparison or hashing is too expensive.
Fedora Account System Username: bgilbert

Comment 1 Fedora Review Service 2024-06-30 14:55:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7693402
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294817-rust-version-track/fedora-rawhide-x86_64/07693402-rust-version-track/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benjamin Gilbert 2024-06-30 15:13:52 UTC
> rust-version-track+default-devel.noarch: E: spelling-error ('comparision', '%description -l en_US comparision -> comparison, compassion, compression')
> rust-version-track.src: E: spelling-error ('comparision', '%description -l en_US comparision -> comparison, compassion, compression')
> rust-version-track-devel.noarch: E: spelling-error ('comparision', '%description -l en_US comparision -> comparison, compassion, compression')

Upstream PR in https://github.com/MitMaro/version-track/pull/10.

Comment 3 Fabio Valentini 2024-07-03 16:34:55 UTC
Thank you for submitting the PR upstream!

Consider adding a rust2rpm.toml config file to the dist-git repo for the Summary override.

===

Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-03 20:43:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-version-track

Comment 5 Fedora Update System 2024-07-03 22:26:03 UTC
FEDORA-2024-19f6316631 (rust-version-track-0.1.0-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-19f6316631

Comment 6 Fedora Update System 2024-07-03 22:29:33 UTC
FEDORA-2024-19f6316631 (rust-version-track-0.1.0-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.