Bug 2294819 - Review Request: rust-captur - Macro to capture whole structs from disjoint fields in a closure
Summary: Review Request: rust-captur - Macro to capture whole structs from disjoint fi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/captur
Whiteboard:
Depends On:
Blocks: 2295731
TreeView+ depends on / blocked
 
Reported: 2024-06-30 15:10 UTC by Benjamin Gilbert
Modified: 2024-07-04 04:39 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-03 22:29:30 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7693473 to 7695161 (580 bytes, patch)
2024-06-30 21:54 UTC, Fedora Review Service
no flags Details | Diff

Description Benjamin Gilbert 2024-06-30 15:10:21 UTC
Spec URL: https://fedorapeople.org/~bgilbert/srpm/rust-captur.spec
SRPM URL: https://fedorapeople.org/~bgilbert/srpm/rust-captur-1.0.0-1.fc40.src.rpm
Description: Macro to capture whole structs from disjoint fields in a closure.
Fedora Account System Username: bgilbert

Comment 1 Fedora Review Service 2024-06-30 15:15:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7693473
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294819-rust-captur/fedora-rawhide-x86_64/07693473-rust-captur/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2024-06-30 21:54:23 UTC
Created attachment 2038569 [details]
The .spec file difference from Copr build 7693473 to 7695161

Comment 4 Fedora Review Service 2024-06-30 21:54:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7695161
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294819-rust-captur/fedora-rawhide-x86_64/07695161-rust-captur/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2024-07-03 16:05:19 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have time, it would be great if you could review some other pending Rust package in turn.

Comment 6 Fedora Admin user for bugzilla script actions 2024-07-03 20:43:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-captur

Comment 7 Fedora Update System 2024-07-03 22:25:49 UTC
FEDORA-2024-0db20f03ae (rust-captur-1.0.0-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0db20f03ae

Comment 8 Fedora Update System 2024-07-03 22:29:30 UTC
FEDORA-2024-0db20f03ae (rust-captur-1.0.0-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.