Spec URL: https://gui1ty.fedorapeople.org/review/python-glfw.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-glfw-2.7.0-1.fc41.src.rpm Description: This module provides Python bindings for GLFW (on GitHub: glfw/glfw). It is a ctypes wrapper which keeps very close to the original GLFW API, except for: - function names use the pythonic `words_with_underscores` notation instead of `camelCase` - `GLFW_` and `glfw` prefixes have been removed, as their function is replaced by the module namespace (you can use `from glfw.GLFW import *` if you prefer the naming convention used by the GLFW C API) - structs have been replaced with Python sequences and namedtuples - functions like `glfwGetMonitors` return a list instead of a pointer and an object count - Gamma ramps use floats between 0.0 and 1.0 instead of unsigned shorts (use `glfw.NORMALIZE_GAMMA_RAMPS=False` to disable this) - GLFW errors are reported as glfw.GLFWError warnings if no error callback is set (use `glfw.ERROR_REPORTING=False` to disable this, set it to `warn` instead to issue warnings, set it to `log` to log it using the `glfw` logger or set it to a dict to define the behavior for specific error codes) - instead of a sequence for `GLFWimage` structs, PIL/pillow `Image` objects can be used Fedora Account System Username: gui1ty
*** Bug 2275305 has been marked as a duplicate of this bug. ***
This package was submitted for review previously (bug 2275305), but that review got stalled. I'm re-submitting it as I need it as a dependency for another package I'm working on.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7707090 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295768-python-glfw/fedora-rawhide-x86_64/07707090-python-glfw/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Should we remove the FE-DEADREVIEW block here? That implies that *this* review is stalled?
Also, FYI, another review ticket was just submitted for this one. I've noted this review there too: https://bugzilla.redhat.com/show_bug.cgi?id=2304151
(In reply to Ankur Sinha (FranciscoD) from comment #4) > Should we remove the FE-DEADREVIEW block here? That implies that *this* > review is stalled? Most certainly! And thanks for catching that. I'm not sure what I was doing there or if that was set when I marked it as duplicate of the previous request. Anyway, this is dependency for `vispy` [1], which I haven't put up for review, yet. More specifically, it's required for the `glfw` extra of that package. Somehow, I lost track of my packaging activities a little... [1] https://pagure.io/neuro-sig/NeuroFedora/issue/560
*** Bug 2304151 has been marked as a duplicate of this bug. ***
I'll take it for review.
Looks good.
Thanks for the review! Probably the shortest review I have received so far. ;) Since you had submitted this for review yourself, would you like to be co-maintainer? Do you need this on any of the stable branches? Otherwise I'll limit it to rawhide/F42 and F41 for now. PS: I'm setting this to POST. Repository creation will set this to RELEASE_PENDING.
Thank you so much for your offer. I'd love to be a co-maintainer, could you please make me one?
Well, the RELEASE_PENDING never happened since the initial repo request failed. But all that seems to be fixed now. I made you a co-maintainer and the package will land in rawhide/F42 and F41 shortly.
FEDORA-2024-ba01ab5a01 (python-glfw-2.7.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ba01ab5a01
FEDORA-2024-c7b1c6686f (python-glfw-2.7.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c7b1c6686f
FEDORA-2024-ba01ab5a01 (python-glfw-2.7.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-c7b1c6686f (python-glfw-2.7.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.