Red Hat Bugzilla – Bug 229647
Review Request: hyperestraier - A full-text search system
Last modified: 2007-11-30 17:11:57 EST
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/hyperestraier.spec SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/hyperestraier-1.4.9-1.fc7.src.rpm Mockbuild log on FC-devel i386: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-hyperestraier.log Description: Hyper Estraier is a full-text search system. You can search lots of documents for some documents including specified words. If you run a web site, it is useful as your own search engine for pages in your site. Also, it is useful as search utilities of mail boxes and file servers. rpmlint on binary rpms: ------------------------------------------- W: hyperestraier-java devel-file-in-non-devel-package /usr/lib/libjestraier.so ------------------------------------------- Well, I don't know well about java package, however I think that there is no need to create another -java-devel package for this .so file. This package depends on qdbm (bug 229478) Co-maintainers are welcome!!
kazehakase (currently I maintain) can use hyperestraier as a search engine.
Some mistakes are found. http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/hyperestraier-1.4.9-2.fc7.src.rpm http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/hyperestraier.spec * Fri Feb 23 2007 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 1.4.9-2 - Remove duplicate files and fix the dependency for main package.
Review: + package builds fine in mock (development i386). + rpmlint is silent for SRPM - rpmlint is NOT silent for RPM. (But following rpmlint warning can be ignored W: hyperestraier-java devel-file-in-non-devel-package /usr/lib/libjestraier.so) + source files match upstream. 70e0533f1ca5247d8187afcb51b8d4e0 hyperestraier-1.4.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + .pc file present. + -devel,-java,-perl, ruby-hyperestraier subpackage exists. + no .la files. + translations are available for Japanese language. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. APPROVED.
Thanks!! Request for CVS admin to import this package: -------------------------------------------- New Package CVS Request ======================= Package Name: hyperestraier Short Description: A full-text search system Owners: mtasaka@ioa.s.u-tokyo.ac.jp Branches: FC-5 FC-6 FC-devel InitialCC: (nobody) --------------------------------------------
branched
Imported for FE-devel/6/5. For FE-5 I had to disable lzo compression support. Closing now. Thank you for reviewing and approving this package!!