Red Hat Bugzilla – Bug 229478
Review Request: qdbm - Quick Database Manager
Last modified: 2007-11-30 17:11:57 EST
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/qdbm.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/qdbm-1.8.74-1.fc7.src.rpm
Mockbuild log on FC7 i386: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-qdbm.log
QDBM is an embedded database library compatible with GDBM and NDBM.
It features hash database and B+ tree database and is developed referring
to GDBM for the purpose of the following three points: higher processing
speed, smaller size of a database file, and simpler API.
rpmlint on binary rpm:
W: qdbm++-devel no-documentation
W: qdbm-java devel-file-in-non-devel-package /usr/lib/libjqdbm.so
Well, I don't know well about java package, however
I think that there is no need to create another -japa-devel
package for this .so file.
Co-maintainers are welcome!!
*** Bug 206238 has been marked as a duplicate of this bug. ***
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM
- rpmlint is NOT for RPM.
(But following rpmlint warning can be ignored
W: qdbm-java devel-file-in-non-devel-package /usr/lib/libjqdbm.so)
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ .pc files present.
+ -devel,-cgi,-java,-perl, qdbm++, qdbm++-devel, ruby-qdbm subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
I submitted hyperestraier (bug 229647) which depends on
Some mistakes are found.
* Fri Feb 23 2007 Mamoru Tasaka <firstname.lastname@example.org> - 1.8.74-2
- Add missing release dependency
- Change group from Development to System Environment
- Remove duplicate files and fix the dependency for main package.
Oops I missed that one. I checked buildlog only and my eyes missed to check
duplicate files when i did rpm -qlvp on RPMS.
Thanks for catching that.
Thank you for reviewing and approving my package!!
Now I write a CVS request to cvs admin for a new package.
New Package CVS Request
Package Name: qdbm
Short Description: Quick Database Manager
Branches: FC-5 FC-6 FC-devel
First, qdbm rebuild succeeded on FC-devel/6/5.
Thank you for review again!!
(Review process changed from NEXTRELEASE -> RAWHIDE)