Spec URL: https://music.fedorapeople.org/python-cascadio.spec SRPM URL: https://music.fedorapeople.org/python-cascadio-0.0.12-1.fc40.src.rpm Description: A Python library which uses OpenCASCADE to convert STEP files to a GLB file which can quickly be loaded by trimesh and other libraries. This is not intended to be a full binding of OpenCASCADE like OCP or PythonOCC. Rather it is intended to be an easy minimal way to load boundary representation files into a triangulated scene in Python. There are a few options for loading STEP geometry in the open-source ecosystem: GMSH, FreeCAD, etc. However nearly all of them use OpenCASCADE under the hood as it is pretty much the only open-source BREP kernel. Fedora Account System Username: music This is an optional dependency that allows python-trimesh to support more formats. It will build on Rawhide only, since it needs OpenCASCADE 7.8. This will be a neuro-sig package.
Preliminary question regarding the license file(s). You've chosen to include the entire LICENSE/ directory as %license. However, OpenCASCADE has been unbundled and the third file in that directory is a simple README file specifying which license file applies to what (cascadio vs. OpenCASCADE). Why not simply include the cascadio license file as specified in `pyproject.toml` and honored by `%pyproject_save_files`?
I figured there was no harm in including the full LICENSE/ directory, including the explanatory https://github.com/trimesh/cascadio/blob/main/LICENSE/README.md, but could probably get by with just LICENSE/LICENSE-cascadio.md. That’s supported by the fact that, as you noticed, pyproject.toml has license = {file = "LICENSE/LICENSE-cascadio.md"} https://github.com/trimesh/cascadio/blob/5218c720929c892fdcc9a7d527992812aa251243/pyproject.toml#L11 However, I can’t just rely on %pyproject_save_files, as no license files at all are included by default. I would still have to write %license LICENSE/LICENSE-cascadio.md manually. According to https://github.com/scikit-build/scikit-build-core/issues/737, this is expected for the scikit-build-core backend.
Note that the spec has %pyproject_save_files -L cascadio rather than %pyproject_save_files -l cascadio
(In reply to Ben Beasley from comment #3) > Note that the spec has > > %pyproject_save_files -L cascadio > > rather than > > %pyproject_save_files -l cascadio I thought you were using `-L` explicitly in order to avoid duplicating the license specified in `pyproject.toml`. I agree there's no harm in including the entire directory. But it may be confusing since OpenCASCADE is actually not part of the deal. Thanks for the clarification. Final decision is up to you.
No blocking issues found. Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== [ ]: Package is not known to require an ExcludeArch tag. => Why not drop i686 right from the start? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2850 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cascadio [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-cascadio-0.0.12-1.fc41.x86_64.rpm python-cascadio-debugsource-0.0.12-1.fc41.x86_64.rpm python-cascadio-0.0.12-1.fc41.src.rpm ============================================================================================================================ rpmlint session starts ============================================================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6lwy40n_')] checks: 32, packages: 3 python-cascadio.src: E: spelling-error ('trimesh', '%description -l en_US trimesh -> trimester, trimmest') python3-cascadio.x86_64: E: spelling-error ('trimesh', '%description -l en_US trimesh -> trimester, trimmest') ====================================================================================== 3 packages and 0 specfiles checked; 2 errors, 0 warnings, 11 filtered, 2 badness; has taken 1.6 s ======================================================================================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-cascadio.x86_64: E: spelling-error ('trimesh', '%description -l en_US trimesh -> trimester, trimmest') 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 7 filtered, 1 badness; has taken 0.3 s Unversioned so-files -------------------- python3-cascadio: /usr/lib64/python3.13/site-packages/cascadio.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/mikedh/cascadio/archive/0.0.12/cascadio-0.0.12.tar.gz : CHECKSUM(SHA256) this package : 7101e2d08f907421dd27358512f9d3edd1439117c17b38c70c8a4cd68edd7b81 CHECKSUM(SHA256) upstream package : 7101e2d08f907421dd27358512f9d3edd1439117c17b38c70c8a4cd68edd7b81 Requires -------- python3-cascadio (rpmlib, GLIBC filtered): libTKCDF.so.7.8()(64bit) libTKDEGLTF.so.7.8()(64bit) libTKDESTEP.so.7.8()(64bit) libTKLCAF.so.7.8()(64bit) libTKMath.so.7.8()(64bit) libTKMesh.so.7.8()(64bit) libTKXCAF.so.7.8()(64bit) libTKXSBase.so.7.8()(64bit) libTKernel.so.7.8()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) python(abi) rtld(GNU_HASH) python-cascadio-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-cascadio: python-cascadio python3-cascadio python3-cascadio(x86-64) python3.13-cascadio python3.13dist(cascadio) python3dist(cascadio) python-cascadio-debugsource: python-cascadio-debugsource python-cascadio-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2297958 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, C/C++, Generic Disabled plugins: Haskell, Ocaml, fonts, Java, PHP, R, Perl, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! > Thanks for the clarification. Final decision is up to you. I think I will switch to %license LICENSE/LICENSE-cascadio.md, and add a brief spec-file comment clarifying the rationale. Thanks for asking about this. > => Why not drop i686 right from the start? Sure, might as well. I got out of the habit of doing this in arched Python libraries after I had to revert it when people later added dependencies that weren’t ExcludeArch, and restoring i686 support in my package was the easiest way to make everything play together. This should be much less of a problem now that noarch packages are never built in i686, though, and the direct dependents of python-trimesh (python-fsleyes and python-fslpy) already exclude i686 in Rawhide.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cascadio
It looked like I missed doing a scratch build on s390x, and there is an endianness-related issue somewhere (even though this code tries to handle endianness). I’m investigating.
FEDORA-2024-4de9bd4a66 (python-cascadio-0.0.12-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4de9bd4a66
FEDORA-2024-4de9bd4a66 (python-cascadio-0.0.12-4.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.