Spec URL: https://decathorpe.fedorapeople.org/rust-compose_spec.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-compose_spec-0.2.0-1.fc40.src.rpm Description: Types for (de)serializing from/to the compose-spec. Fedora Account System Username: decathorpe
Copr build: https://copr.fedorainfracloud.org/coprs/build/7997584 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2310717-rust-compose_spec/fedora-rawhide-x86_64/07997584-rust-compose_spec/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The package has two features, serde and derive. Your spec file produces only rust-compose_spec-devel though. Shouldn't it produce at least rust-compose_spec+derive-devel as well? Dependencies for that one are there.
> The package has two features, serde and derive. Are you sure you looked at the correct thing? The Cargo.toml in this crates has *no* [features] table at all, and the package *does* have a subpackage for the implicitly always defined "default" feature.
(In reply to Fabio Valentini from comment #3) > > The package has two features, serde and derive. > > Are you sure you looked at the correct thing? You're right. I forgot how to interpret those things. Sorry for that. It's not that this package offers features, but request only some features from its dependencies. Speaking of that, it requires the serde feature from indexmap 2.2.3, but in Fedora there is the incompatible 2.5.0 version. Do you plan on creating rust-indexmap2.2?
It depends on indexmap ^2.2.3, which translates to >=2.2.3,<3 - which is compatible with 2.5.
[fedora-review-service-build]
Please don't wait for the review service to build. It looks like it doesn't like this ticket. Just run the checks locally.
I did so, and found no issues. === Package was generated with rust2rpm (+ probably rust2rpm.toml not presented here), simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === BTW, if you have time and are willing to approve based only on the f39 and f40 possitive results, then please review https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-compose_spec
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b9e3c1384b